-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(optimizer): add generic keyset info generation #1145
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: af46cf4 | Previous: f2e53f8 | Ratio |
---|---|---|---|
v0 PBS table generation |
61377116 ns/iter (± 1572781 ) |
61398249 ns/iter (± 643937 ) |
1.00 |
v0 PBS simulate dag table generation |
38177850 ns/iter (± 305049 ) |
38363387 ns/iter (± 519252 ) |
1.00 |
v0 WoP-PBS table generation |
52539831 ns/iter (± 3051361 ) |
52792136 ns/iter (± 2407551 ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
aPere3
force-pushed
the
alex/optimizer_keyset_generation
branch
3 times, most recently
from
November 18, 2024 09:12
c04a462
to
87b9f0e
Compare
BourgerieQuentin
requested changes
Nov 19, 2024
compilers/concrete-compiler/compiler/include/concretelang/Common/Keysets.h
Outdated
Show resolved
Hide resolved
compilers/concrete-optimizer/concrete-optimizer-cpp/src/cpp/concrete-optimizer.cpp
Show resolved
Hide resolved
...ete-optimizer/concrete-optimizer/src/optimization/dag/multi_parameters/generic_generation.rs
Outdated
Show resolved
Hide resolved
...ete-optimizer/concrete-optimizer/src/optimization/dag/multi_parameters/generic_generation.rs
Outdated
Show resolved
Hide resolved
...ete-optimizer/concrete-optimizer/src/optimization/dag/multi_parameters/generic_generation.rs
Outdated
Show resolved
Hide resolved
...ete-optimizer/concrete-optimizer/src/optimization/dag/multi_parameters/generic_generation.rs
Outdated
Show resolved
Hide resolved
aPere3
force-pushed
the
alex/optimizer_keyset_generation
branch
2 times, most recently
from
November 21, 2024 14:08
680313a
to
f2e53f8
Compare
BourgerieQuentin
approved these changes
Nov 21, 2024
aPere3
force-pushed
the
alex/optimizer_keyset_generation
branch
from
November 22, 2024 09:18
f2e53f8
to
655172d
Compare
aPere3
force-pushed
the
alex/optimizer_keyset_generation
branch
from
November 22, 2024 09:28
655172d
to
af46cf4
Compare
BourgerieQuentin
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss already optimized partition right?
BourgerieQuentin
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.