Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add markdown link check #398

Merged
merged 2 commits into from
Oct 27, 2023
Merged

chore(ci): add markdown link check #398

merged 2 commits into from
Oct 27, 2023

Conversation

aquint-zama
Copy link
Contributor

@aquint-zama aquint-zama commented May 4, 2023 •
edited by RomanBredehoft
Loading

@cla-bot cla-bot bot added the cla-signed label May 4, 2023
@aquint-zama aquint-zama marked this pull request as draft May 4, 2023 13:35
@bcm-at-zama
Copy link
Contributor

that's a pretty different technique than what we have on ML side. Is there things that @zama-ai/ml team should borrow?

@aquint-zama aquint-zama force-pushed the feat/add-link-checker branch 3 times, most recently from e48bb6c to e428d79 Compare October 2, 2023 09:57
@aquint-zama aquint-zama marked this pull request as ready for review October 2, 2023 10:10
@aquint-zama
Copy link
Contributor Author

⚠️ There are some broken links to backport to the release/2.4.x branch (maybe even the older 2.3)

bcm-at-zama
bcm-at-zama reviewed Oct 2, 2023
View reviewed changes
bcm-at-zama
bcm-at-zama reviewed Oct 2, 2023
View reviewed changes
bcm-at-zama
bcm-at-zama reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aquint-zama , I let people in the team do the PR. I think you added the files from your other PR (tricks).

@aquint-zama
chore(ci): add markdown link check
4744776
@aquint-zama
docs(frontend): fix broken links
e18aa7a 
and ignore those that cant be automatically checked (sadly)
@aquint-zama aquint-zama force-pushed the feat/add-link-checker branch from e428d79 to e18aa7a Compare October 2, 2023 12:43
@rudy-6-4 rudy-6-4 merged commit 8595aad into main Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcm-at-zama bcm-at-zama bcm-at-zama left review comments

@umut-sahin umut-sahin umut-sahin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aquint-zama @bcm-at-zama @umut-sahin @rudy-6-4