-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Detailed Statistics #526
Conversation
compilers/concrete-compiler/compiler/include/concretelang/Dialect/TFHE/IR/TFHETypes.td
Outdated
Show resolved
Hide resolved
compilers/concrete-compiler/compiler/include/concretelang/Support/CompilationFeedback.h
Outdated
Show resolved
Hide resolved
compilers/concrete-compiler/compiler/include/concretelang/Dialect/TFHE/IR/TFHETypes.td
Outdated
Show resolved
Hide resolved
compilers/concrete-compiler/compiler/lib/Dialect/TFHE/Analysis/ExtractStatistics.cpp
Outdated
Show resolved
Hide resolved
6d7e0e6
to
309fa5f
Compare
90804b9
to
b4ab47a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why querying stats (e.g. to get the count of an operation per tag), is implemented in Python, and at the CP level. This is a feature that should be implemented in Cpp in the CompilerFeedback class (thus available to be supported in the Rust bindings or the CAPI), and exposed through the python bindings to CP.
Because it's much easier to implement, and we have a lot more things to do. We can move it to C++ when it's beneficial to do so. Also, I'd much prefer to replicate this logic (which is 4 function at core) in Rust, than to do it in C++. As for the CAPI, we can't return a hashmap there anyway. |
While I'm not a fan of adding this outside of the Compiler Cpp codebase, the only way I would see this be kept outside of Cpp, is this feature being implemented under |
b4ab47a
to
04ef8a9
Compare
Done. |
04ef8a9
to
e40a499
Compare
No description provided.