-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uniformize examples readme and quickstart [ready for reviews] #704
Uniformize examples readme and quickstart [ready for reviews] #704
Conversation
@BourgerieQuentin , @umut-sahin , you'll tell me if you're fine with these changes. And then, we'll have to handle the conflicts in the other PR by @yuxizama (#700) |
fc7f6d3
to
34c8085
Compare
Let me fix the build. |
Note that we could squash the commits, I just made them separate for you to have a look to my changes in the example itself. |
And we can make it reviewed by an English native speaker before pushing. |
8aa6dab
to
c910554
Compare
Thanks @BourgerieQuentin for your feedback. Do you want to take the lead now on this PR, and change what you want? What we need at least is to uniformize the README and QuickStart. For the rest, you can do what you want. Just maybe wait that #700 is merged before merging this one. |
b07013f
to
503e6ed
Compare
any feedback @bcm-at-zama @yuxizama ? |
Thx, let me have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike the fact that it has been over simplified:
- for newbies: it's not clear to me that they shouldn't hardcode their inputset; it's not clear that they should have long inputset
- for developers: I use the README to have a template I can change; each time I'll have to re-add what I did previously in this PR, which is having random and with a chosen-bit width inputs.
But I guess we have to converge so I'll accept.
Let me make this build green. |
503e6ed
to
a4cf3a0
Compare
Rebased and fixed lint |
Build is green |
a4cf3a0
to
3ed0338
Compare
Rebasing |
3ed0338
to
c614b69
Compare
pushed on release/v2.6.0 |
Mainly, this PR is to unify examples in README and in quick_start.md, as requested by @yuxizama.
closes zama-ai/concrete-internal#603
By the way, I used the opportunity to update a bit the example
I find this example easier to be reused for users (eg, me, each time, I apply this very same change). Is it ok with you?