fix(compiler): Do not omit assignment of optimizer ID to FHE.reinterpret_precision #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BourgerieQuentin
approved these changes
Mar 6, 2024
…ret_precision The DAG pass establishing a mapping between operations in the IR and the optimizer DAG currently omits assignment of the optimizer ID to `FHE.reinterpret_precision` operations via the `TFHE.OId` attribute. This prevents subsequent passes from determining to which optimizer partition a `FHE.reinterpret_precision` operation belongs. This commit removes the early exit in `FunctionToDag::addOperation` for the handling of `FHE.reinterpret_precision` that prevented the code assigning the optimizer ID from being executed.
andidr
force-pushed
the
andi/optimizer-fixes
branch
from
6567849
to
282caca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DAG pass establishing a mapping between operations in the IR and the optimizer DAG currently omits assignment of the optimizer ID to
FHE.reinterpret_precisionoperations via theTFHE.OIdattribute. This prevents subsequent passes from determining to which optimizer partition aFHE.reinterpret_precisionoperation belongs.This commit removes the early exit in
FunctionToDag::addOperationfor the handling ofFHE.reinterpret_precisionthat prevented the code assigning the optimizer ID from being executed.