Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workspace): fix new clippy lints #83

Merged
merged 2 commits into from
Sep 30, 2021
Merged

fix(workspace): fix new clippy lints #83

merged 2 commits into from
Sep 30, 2021

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Sep 30, 2021

Please check if the PR fulfills these requirements

(please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The PR description links to the related issue (to link an issue, use '#XXX'.)
  • The tests on AWS have been launched and are successful (apply the aws_label to the PR to launch the tests on AWS)
  • The draft release description has been updated

Resolves: zama-ai/concrete_internal#135

Description

New lints were added to clippy, and that broke the CI. This commit fixes it.

@aPere3 aPere3 added the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@github-actions github-actions bot removed the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@aPere3 aPere3 added the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@agnesLeroy agnesLeroy self-requested a review September 30, 2021 13:16
@github-actions github-actions bot removed the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@agnesLeroy agnesLeroy added the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@github-actions github-actions bot removed the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@agnesLeroy agnesLeroy added the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
@github-actions github-actions bot removed the aws_test A label to trigger the test execution on aws instance label Sep 30, 2021
The use of the nighty compiler to test the library (required to compute
coverage) broke the CI. This commit removes it.
@aPere3 aPere3 merged commit 2b70506 into master Sep 30, 2021
@aPere3 aPere3 deleted the fix/clippy branch September 30, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants