Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): fixing a broken path #835

Merged
merged 1 commit into from
May 27, 2024

Conversation

sukrucildirr
Copy link
Contributor

I fixed broken file path of "Execution/Analysis"

@cla-bot cla-bot bot added the cla-signed label May 17, 2024
@bcm-at-zama
Copy link
Contributor

@yuxizama , apparently we have broken path for Execution/Analysis
Should we take this external commit?

@yuxizama
Copy link
Contributor

@bcm-at-zama
It looks good to me, the fix is correct. I think we can take it.

@bcm-at-zama
Copy link
Contributor

Thanks @yuxizama
@aquint-zama , do we have the signed CLA for @sukrucildirr please?

@bcm-at-zama
Copy link
Contributor

And then we'll have the commit message fixed

@sukrucildirr
Copy link
Contributor Author

Thanks @yuxizama @aquint-zama , do we have the signed CLA for @sukrucildirr please?

I had signed CLA.

@aquint-zama
Copy link
Contributor

aquint-zama commented May 22, 2024

@aquint-zama , do we have the signed CLA for @sukrucildirr please?

Yes that's why cla-bot already labeled this PR with cla-signed label

@bcm-at-zama
Copy link
Contributor

ok thx. So @sukrucildirr , could you reword your commit message please, to follow our rules? it could be eg

fix(compiler): fixing a broken path

Then, we'll have the CI green. Thanks

@sukrucildirr sukrucildirr changed the title Fix broken file path fix(compiler): fixing a broken path May 22, 2024
@sukrucildirr
Copy link
Contributor Author

ok thx. So @sukrucildirr , could you reword your commit message please, to follow our rules? it could be eg

fix(compiler): fixing a broken path

Then, we'll have the CI green. Thanks

I did. Thanks.

@bcm-at-zama
Copy link
Contributor

The CI is still red.

You can see

Run gsactions/commit-message-checker@v1
Checking commit messages against "^(feat|fix|test|bench|docs|chore|refactor|perf)\((compiler|backend|frontend|optimizer|tools|ci|common).*\):"...
- failed: "Update README.md"
Error: Error: Your first line has to contain a commit type and scope like "feat(my_feature): msg".

and indeed, your commit message is still "Update README.md". Could you retry the rewording, please?

@sukrucildirr
Copy link
Contributor Author

The CI is still red.

You can see

Run gsactions/commit-message-checker@v1
Checking commit messages against "^(feat|fix|test|bench|docs|chore|refactor|perf)\((compiler|backend|frontend|optimizer|tools|ci|common).*\):"...
- failed: "Update README.md"
Error: Error: Your first line has to contain a commit type and scope like "feat(my_feature): msg".

and indeed, your commit message is still "Update README.md". Could you retry the rewording, please?

Sorry, my misunderstand. I reword it.

@bcm-at-zama
Copy link
Contributor

Thx, running the full CI

@bcm-at-zama
Copy link
Contributor

Hum, we stil have some red CI here (not your fault @sukrucildirr). Let us check

@BourgerieQuentin , do you know what

0s
Run actions/checkout@v3
with:
fetch-depth: 0
repository: zama-ai/concrete
ssh-strict: true
persist-credentials: true
clean: true
sparse-checkout-cone-mode: true
fetch-tags: false
lfs: false
submodules: false
set-safe-directory: true
Error: Input required and not supplied: token

is about?

@BourgerieQuentin
Copy link
Member

Hum, we stil have some red CI here (not your fault @sukrucildirr). Let us check

@BourgerieQuentin , do you know what

0s
Run actions/checkout@v3
with:
fetch-depth: 0
repository: zama-ai/concrete
ssh-strict: true
persist-credentials: true
clean: true
sparse-checkout-cone-mode: true
fetch-tags: false
lfs: false
submodules: false
set-safe-directory: true
Error: Input required and not supplied: token

is about?

Yes I see why is doesn't work, I'll make a PR later. The whole CI not need to be run for this PR.

@BourgerieQuentin BourgerieQuentin merged commit aa6e5d9 into zama-ai:main May 27, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants