Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(frontend): refactor the doc for modules #890

Merged
merged 1 commit into from
Jun 17, 2024
Merged

doc(frontend): refactor the doc for modules #890

merged 1 commit into from
Jun 17, 2024

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Jun 14, 2024

No description provided.

@aPere3
Copy link
Collaborator Author

aPere3 commented Jun 14, 2024

closes zama-ai/concrete-internal#713

@bcm-at-zama
Copy link
Contributor

Thx @aPere3 . I propose:

Sorry for the back and forth, but now, I think making a section and having not too long (but coherent together) files is the way to go. Something like:

* Composing functions with modules
    * [Title-to-be-found] (compilation/composing_functions_with_modules_part1.md)
    * [Title-to-be-found] (compilation/composing_functions_with_modules_part2.md)

@bcm-at-zama
Copy link
Contributor

good for you, @aPere3 @BourgerieQuentin ?

@aPere3
Copy link
Collaborator Author

aPere3 commented Jun 14, 2024

Sure good for me !

@bcm-at-zama
Copy link
Contributor

@aPere3 : I saw with @BourgerieQuentin and it is ok for him as well.
Could you merge #890 and then I continue in #876
Thanks

Copy link
Contributor

@bcm-at-zama bcm-at-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@bcm-at-zama
Copy link
Contributor

Maybe just fix the md CI problem, to not break other issues @aPere3

@aPere3 aPere3 merged commit ba7229e into main Jun 17, 2024
28 checks passed
@aPere3 aPere3 deleted the doc/modules branch June 17, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants