-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(frontend): adding a section for most common errors #897
Conversation
cf06c1a
to
7c4ea8c
Compare
CC @umut-sahin and @youben11 , for when you're back. Certainly we'll have merged but it may be interesting to have your review when you are available |
Would be nice to merge that not too late, for Yuxi being able to review it |
7c4ea8c
to
2577cc9
Compare
2577cc9
to
3a8208f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great start. We must update it each time a user have an error.
@umut-sahin @youben11 : as you are the people with the best knowledge of the frontend (no offense for the others!), could you have a look when you're back and maybe improve / add new typical errors, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start!
**Possible solutions**: | ||
- Try to simplify your circuit | ||
- Use smaller weights, | ||
- Add intermediate PBS to reduce the noise, with identity function `fhe.univariate(lambda x: x)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have fhe.identity(x)
which is better in most cases (though it uses reinterpret so it wouldn't work on CRT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could keep it like this: it's for non power users so let's keep something which is less optimized but works more often, ok?
Adding a list of most common errors with CP. If ever you have other issues you would like to add, don't hesitate to do it or ask me to do it
closes #https://github.com/zama-ai/concrete-internal/issues/719
closes #https://github.com/zama-ai/concrete-internal/issues/508