Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend-python): fix key value database example #913

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

umut-sahin
Copy link
Contributor

(closes #865)

@umut-sahin umut-sahin requested a review from bcm-at-zama June 24, 2024 13:51
@umut-sahin umut-sahin self-assigned this Jun 24, 2024
@cla-bot cla-bot bot added the cla-signed label Jun 24, 2024
@bcm-at-zama
Copy link
Contributor

Thx. Should be reviewed by someone from the team, I think (more than by me)

@bcm-at-zama
Copy link
Contributor

By the way, could we have tests of the examples in the CI, please? I already made an issue for it, I can find it

Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please change the base to release/v2.7.0

@umut-sahin
Copy link
Contributor Author

By the way, could we have tests of the examples in the CI, please? I already made an issue for it, I can find it

Can we do this in a separate PR? I think we shouldn't copy the example code into our tests (as it'd be duplication and hard to manage), instead we can just run the scripts and make sure it exits without any assertion errors.

Wdyt?

@bcm-at-zama
Copy link
Contributor

Yes it can be in a further PR but we shouldn't delay this further PR too late please.

To me, it's not about copying some code: it's about launching the different .py / .sh in the example directories, and checking it's green (in the CI). So, another action to set

@umut-sahin
Copy link
Contributor Author

Sure, let's create another PR to run the examples!

@umut-sahin umut-sahin merged commit 2c9455a into main Jun 25, 2024
29 of 31 checks passed
@umut-sahin umut-sahin deleted the fix/kvdb branch June 25, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key-value database examples not working (seems to be a regression in 2.6.0, used to work for 2.5.0)
3 participants