Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(frontend): massive modifications in the documentation [part 1] #944

Merged
merged 1 commit into from
Jul 24, 2024
Merged

docs(frontend): massive modifications in the documentation [part 1] #944

merged 1 commit into from
Jul 24, 2024

Conversation

bcm-at-zama
Copy link
Contributor

@bcm-at-zama bcm-at-zama commented Jul 17, 2024 •
edited
Loading

See #812

  • part 1
  • part 2
  • part 3
  • part 4
  • part 5
  • part 6
  • part 7
  • part 8
  • part 9
  • part 10
  • part 11

@cla-bot cla-bot bot added the cla-signed label Jul 17, 2024
@bcm-at-zama bcm-at-zama marked this pull request as draft July 17, 2024 17:09
@bcm-at-zama bcm-at-zama force-pushed the refacto_doc_812 branch 2 times, most recently from 82a9d0e to 7ac889e Compare July 18, 2024 13:58
@bcm-at-zama bcm-at-zama marked this pull request as ready for review July 19, 2024 13:30
@bcm-at-zama
Copy link
Contributor Author

I missed to make it "ready for review" sorry. @yuxizama , what do you think? Let's merge this and then I continue

@bcm-at-zama bcm-at-zama mentioned this pull request Jul 22, 2024
Merged
2 tasks
@bcm-at-zama bcm-at-zama changed the title docs(frontend): massive modifications in the documentation docs(frontend): massive modifications in the documentation [part 1] Jul 22, 2024
yuxizama
yuxizama reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bcm-at-zama, thank you for the improvements!
I've added some suggestions, you can have a look

docs/SUMMARY.md Outdated Show resolved Hide resolved
docs/SUMMARY.md Outdated Show resolved Hide resolved
docs/SUMMARY.md Show resolved Hide resolved
docs/get-started/limitations.md Outdated Show resolved Hide resolved
docs/get-started/terminology.md Outdated Show resolved Hide resolved
docs/get-started/terminology.md Outdated Show resolved Hide resolved
@bcm-at-zama bcm-at-zama force-pushed the refacto_doc_812 branch 2 times, most recently from 1735d0f to b385ee6 Compare July 23, 2024 15:56
@bcm-at-zama
Copy link
Contributor Author

Good for you @yuxizama ? Can we merge this?

yuxizama
yuxizama approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bcm-at-zama bcm-at-zama merged commit c777b4c into main Jul 24, 2024
11 of 13 checks passed
@bcm-at-zama bcm-at-zama deleted the refacto_doc_812 branch July 24, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxizama yuxizama yuxizama approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcm-at-zama @yuxizama