feat(frontend): wire tracing

[aPere3]

No description provided.

[bcm-at-zama]

Maybe you could update the doc as well, in the same PR? Doing so, it would help me understand how the new feature works. Thanks!

[bcm-at-zama]

Some more comments.

In general:

• please do not have me as a single reviewer. I added @umut-sahin
• I would say we miss a lot of comments
• I would prefer to have the doc here as well, to understand how it works, and be able to say what I think
• ideally, the tests would be with a more-complex-control-flow function. Else, I am afraid we don't really check the auto wiring.

[umut-sahin]

The API is usable, but I think we talked about some kind of pipeline API, in which the wires would be detected + a single inputset would be given for the whole pipeline. Did we give up on that idea, or is this one just a temporary solution until then?

[BourgerieQuentin]

I schedule a meeting when @aPere3, with @umut-sahin come back to discuss of that and the API.

[BourgerieQuentin]

Ok look good to me, I'm just wondering in term of API if we could declare the pipeline as a composition policy directly?
Something like

@fhe.module()
class Module:
   ...

   composition = fhe.Pipeline(inputset, lambda sample: Module.c(Module.b(Module.a(s))))

[aPere3]

Ok look good to me, I'm just wondering in term of API if we could declare the pipeline as a composition policy directly? Something like

@fhe.module()
class Module:
   ...

   composition = fhe.Pipeline(inputset, lambda sample: Module.c(Module.b(Module.a(s))))

Module would not be defined here, so we would need to pass the Module to the lambda. We talked about that with @umut-sahin , and settled on the current API.

[BourgerieQuentin]

Ok look good to me, I'm just wondering in term of API if we could declare the pipeline as a composition policy directly? Something like

@fhe.module()
class Module:
   ...

   composition = fhe.Pipeline(inputset, lambda sample: Module.c(Module.b(Module.a(s))))

Module would not be defined here, so we would need to pass the Module to the lambda. We talked about that with @umut-sahin , and settled on the current API.

Ok that's what I expected but as I'm not an python expert and as we can do weird things in python I'm wondering if it was possible :). 👍

So I think it could be great to not to have to set an empty fhe.Wired composition rule just for readability. But that can be done in a next PR. wdyt?

[BourgerieQuentin]

@yuxizama the PR is ready for doc review

[aPere3]

So I think it could be great to not to have to set an empty fhe.Wired composition rule just for readability. But that can be done in a next PR. wdyt?

Yes, I was not sure about the what you guys would prefer so I left it this way, but I'll change it to automatically set the proper policy.

No worries, I'll do it there. It's a small change, and CI is still not green anyway.

[umut-sahin]

It looks good to me, I'm just curious about how it'll work in practice.

[aPere3]

It looks good to me, I'm just curious about how it'll work in practice.

What do you mean ?

[bcm-at-zama]

Thanks for the doc @aPere3 . Just asking a change for SHA1, for also use modules please, thanks

[yuxizama]

Some suggestions, thank you!

[bcm-at-zama]

Thanks @aPere3