docs(compiler): adding a tutorial with floats #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcm-at-zama
force-pushed
the
adding_a_float_tutorial_744
branch
8 times, most recently
from
c2c4a86
to
157d443
Compare
|
That's a first version: could you tell me guys what you think about it? I can make it more complicated or different if you have suggestions. |
|
Except the coverage thing, which is not related to this PR, it's ready, CC @umut-sahin . Could I have a review please |
umut-sahin
suggested changes
Aug 8, 2024
frontends/concrete-python/examples/floating_point/floating_point.ipynb
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/floating_point/floating_point.ipynb
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/floating_point/floating_point.ipynb
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/floating_point/floating_point.ipynb
Outdated
Show resolved
Hide resolved
BourgerieQuentin
approved these changes
Aug 8, 2024
bcm-at-zama
force-pushed
the
adding_a_float_tutorial_744
branch
from
157d443
to
e805fb4
Compare
|
I've applied your proposals @umut-sahin , tell me what you think about it! |
bcm-at-zama
force-pushed
the
adding_a_float_tutorial_744
branch
from
e805fb4
to
094232e
Compare
bcm-at-zama
force-pushed
the
adding_a_float_tutorial_744
branch
from
094232e
to
e348159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a tutorial, to answer common questions about "how to deal with floats in CP"
closes https://github.com/zama-ai/concrete-internal/issues/744