Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): accept clear arguments in server.run #989

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

umut-sahin
Copy link
Contributor

@umut-sahin umut-sahin self-assigned this Aug 12, 2024
@cla-bot cla-bot bot added the cla-signed label Aug 12, 2024
@umut-sahin umut-sahin force-pushed the server-run-with-clear branch from 1ca2b90 to 0b5449d Compare August 12, 2024 12:51
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to add a way to not generate the keyset and make it works and tests for modules too

Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, take a look and good to merge

@umut-sahin umut-sahin force-pushed the server-run-with-clear branch from b5dc9ff to 069f902 Compare August 12, 2024 14:05
@umut-sahin umut-sahin force-pushed the server-run-with-clear branch from 069f902 to 62caf9f Compare August 12, 2024 15:06
@umut-sahin umut-sahin merged commit bb52dbb into main Aug 12, 2024
31 of 33 checks passed
@umut-sahin umut-sahin deleted the server-run-with-clear branch August 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants