Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(compiler): add releasing process #998

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

bcm-at-zama
Copy link
Contributor

@cla-bot cla-bot bot added the cla-signed label Aug 13, 2024
@bcm-at-zama bcm-at-zama force-pushed the add_releasing_to_docs_759 branch 2 times, most recently from 42edb94 to 5d78adb Compare August 14, 2024 13:09
@bcm-at-zama bcm-at-zama marked this pull request as ready for review August 14, 2024 15:09
@BourgerieQuentin BourgerieQuentin force-pushed the add_releasing_to_docs_759 branch 3 times, most recently from a502338 to c28e073 Compare August 14, 2024 16:18
@bcm-at-zama
Copy link
Contributor Author

@BourgerieQuentin : I've made updates, if you want to check

@bcm-at-zama
Copy link
Contributor Author

If ok with you @BourgerieQuentin , we'll add Yuxi as a reviewer as well

Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bcm-at-zama @BourgerieQuentin, this doc seems to be our internal process, do we expect external users to create new release branches?

@bcm-at-zama
Copy link
Contributor Author

Hey @bcm-at-zama @BourgerieQuentin, this doc seems to be our internal process, do we expect external users to create new release branches?

To me, it's a good thing to have the full doc in a central place, instead of having fragmented doc a bit everywhere, in Notion and elsewhere. It's not bad or dangerous to put this doc in the common doc.

@yuxizama
Copy link
Contributor

yuxizama commented Aug 22, 2024

IMO It's very weird to have this in public product documentation. It's not very useful to users and adds noise to documentation. If the purpose is to facilitate our internal work, I suggest moving it into Notion, instead of doc.

@bcm-at-zama
Copy link
Contributor Author

IMO It's very weird to have this in public product documentation. It's not very useful to users and adds noise to documentation. If the purpose is to facilitate our internal work, I suggest moving it into Notion, instead of doc.

it's in a part of the doc that no external user will go to, in my opinion; it's the doc of a process which may be doable by 3rd parties if Concrete was a project managed by several companies, it's not so crazy to have it in the doc, to me. If we don't have it, it's going to be on Notion and never updated / people will never go there.

@yuxizama
Copy link
Contributor

It still doesn't make much sense to me. But if you insist, you can proceed and merge it. It's not a very big deal.

@bcm-at-zama
Copy link
Contributor Author

Then let's merge, thx

@BourgerieQuentin BourgerieQuentin force-pushed the add_releasing_to_docs_759 branch from 7b7d315 to a8dcb89 Compare August 23, 2024 12:41
@BourgerieQuentin BourgerieQuentin merged commit 666e7f5 into main Aug 23, 2024
27 of 28 checks passed
@BourgerieQuentin BourgerieQuentin deleted the add_releasing_to_docs_759 branch August 23, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants