-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(compiler): add releasing process #998
Conversation
42edb94
to
5d78adb
Compare
a502338
to
c28e073
Compare
@BourgerieQuentin : I've made updates, if you want to check |
If ok with you @BourgerieQuentin , we'll add Yuxi as a reviewer as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bcm-at-zama @BourgerieQuentin, this doc seems to be our internal process, do we expect external users to create new release branches?
To me, it's a good thing to have the full doc in a central place, instead of having fragmented doc a bit everywhere, in Notion and elsewhere. It's not bad or dangerous to put this doc in the common doc. |
IMO It's very weird to have this in public product documentation. It's not very useful to users and adds noise to documentation. If the purpose is to facilitate our internal work, I suggest moving it into Notion, instead of doc. |
it's in a part of the doc that no external user will go to, in my opinion; it's the doc of a process which may be doable by 3rd parties if Concrete was a project managed by several companies, it's not so crazy to have it in the doc, to me. If we don't have it, it's going to be on Notion and never updated / people will never go there. |
It still doesn't make much sense to me. But if you insist, you can proceed and merge it. It's not a very big deal. |
Then let's merge, thx |
7b7d315
to
a8dcb89
Compare
closes https://github.com/zama-ai/concrete-internal/issues/759