-
-
Notifications
You must be signed in to change notification settings - Fork 688
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #5536 from psiinon/pscanbeta/polyfill
Pscanbeta - add polyfill.io scan rule
- Loading branch information
Showing
5 changed files
with
427 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
146 changes: 146 additions & 0 deletions
146
...eta/src/main/java/org/zaproxy/zap/extension/pscanrulesBeta/PolyfillCdnScriptScanRule.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,146 @@ | ||
| /* | ||
| * Zed Attack Proxy (ZAP) and its related class files. | ||
| * | ||
| * ZAP is an HTTP/HTTPS proxy for assessing web application security. | ||
| * | ||
| * Copyright 2024 The ZAP Development Team | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.zaproxy.zap.extension.pscanrulesBeta; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.regex.Matcher; | ||
| import java.util.regex.Pattern; | ||
| import net.htmlparser.jericho.Element; | ||
| import net.htmlparser.jericho.HTMLElementName; | ||
| import net.htmlparser.jericho.Source; | ||
| import org.parosproxy.paros.Constant; | ||
| import org.parosproxy.paros.core.scanner.Alert; | ||
| import org.parosproxy.paros.network.HttpMessage; | ||
| import org.zaproxy.addon.commonlib.CommonAlertTag; | ||
| import org.zaproxy.zap.extension.pscan.PluginPassiveScanner; | ||
|
|
||
| public class PolyfillCdnScriptScanRule extends PluginPassiveScanner | ||
| implements CommonPassiveScanRuleInfo { | ||
|
|
||
| /** Prefix for internationalised messages used by this rule */ | ||
| private static final String MESSAGE_PREFIX = "pscanbeta.polyfillcdnscript."; | ||
|
|
||
| private static final Map<String, String> ALERT_TAGS = | ||
| CommonAlertTag.toMap( | ||
| CommonAlertTag.OWASP_2021_A06_VULN_COMP, | ||
| CommonAlertTag.OWASP_2017_A09_VULN_COMP); | ||
|
|
||
| private static final int PLUGIN_ID = 10115; | ||
|
|
||
| private static Pattern POLYFILL_IO = | ||
| Pattern.compile("http[s]?://.*polyfill\\.io/.*", Pattern.CASE_INSENSITIVE); | ||
|
|
||
| @Override | ||
| public void scanHttpResponseReceive(HttpMessage msg, int id, Source source) { | ||
| if (msg.getResponseBody().length() > 0 && msg.getResponseHeader().isHtml()) { | ||
| List<Element> sourceElements = source.getAllElements(HTMLElementName.SCRIPT); | ||
| boolean alertRaised = false; | ||
| if (sourceElements != null) { | ||
| for (Element sourceElement : sourceElements) { | ||
| String src = sourceElement.getAttributeValue("src"); | ||
| if (src != null && POLYFILL_IO.matcher(src).matches()) { | ||
| this.createHighConfidenceAlert(src, sourceElement.toString()).raise(); | ||
| alertRaised = true; | ||
| } | ||
| } | ||
| if (alertRaised) { | ||
| // Definitely an issue, no point checking the script contents | ||
| return; | ||
| } | ||
| // Check the script contents, in case they are loading scripts via JS | ||
| for (Element sourceElement : sourceElements) { | ||
| String contents = sourceElement.getContent().toString(); | ||
| Matcher matcher = POLYFILL_IO.matcher(contents); | ||
| if (matcher.find()) { | ||
| this.createLowConfidenceAlert(null, matcher.group(0)).raise(); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private AlertBuilder createHighConfidenceAlert(String param, String evidence) { | ||
| return this.createAlert( | ||
| Alert.CONFIDENCE_HIGH, | ||
| Constant.messages.getString(MESSAGE_PREFIX + "desc1"), | ||
| param, | ||
| evidence, | ||
| 1); | ||
| } | ||
|
|
||
| private AlertBuilder createLowConfidenceAlert(String param, String evidence) { | ||
| return this.createAlert( | ||
| Alert.CONFIDENCE_LOW, | ||
| Constant.messages.getString(MESSAGE_PREFIX + "desc2"), | ||
| param, | ||
| evidence, | ||
| 2); | ||
| } | ||
|
|
||
| private AlertBuilder createAlert( | ||
| int confidence, String description, String param, String evidence, int alertRef) { | ||
| return newAlert() | ||
| .setRisk(getRisk()) | ||
| .setConfidence(confidence) | ||
| .setDescription(description) | ||
| .setParam(param) | ||
| .setSolution(Constant.messages.getString(MESSAGE_PREFIX + "soln")) | ||
| .setReference(Constant.messages.getString(MESSAGE_PREFIX + "refs")) | ||
| .setEvidence(evidence) | ||
| .setCweId(829) // CWE Id 829 - Inclusion of Functionality from Untrusted Control | ||
| // Sphere) | ||
| .setWascId(15) // WASC-15: Application Misconfiguration) | ||
| .setAlertRef(PLUGIN_ID + "-" + alertRef); | ||
| } | ||
|
|
||
| @Override | ||
| public List<Alert> getExampleAlerts() { | ||
| return List.of( | ||
| createHighConfidenceAlert( | ||
| "https://cdn.polyfill.io/malicious.js", | ||
| "<script type=\"text/javascript\" src=\"https://cdn.polyfill.io/malicious.js\"></script>") | ||
| .build(), | ||
| createLowConfidenceAlert( | ||
| "https://cdn.polyfill.io/malicious.js", | ||
| "<script> script = \"https://cdn.polyfill.io/malicious.js\"; </script>") | ||
| .build()); | ||
| } | ||
|
|
||
| @Override | ||
| public int getPluginId() { | ||
| return PLUGIN_ID; | ||
| } | ||
|
|
||
| public int getRisk() { | ||
| return Alert.RISK_HIGH; | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() { | ||
| return Constant.messages.getString(MESSAGE_PREFIX + "name"); | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, String> getAlertTags() { | ||
| return ALERT_TAGS; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.