diff --git a/addOns/exim/CHANGELOG.md b/addOns/exim/CHANGELOG.md index 2613eced74..2ed0801fc8 100644 --- a/addOns/exim/CHANGELOG.md +++ b/addOns/exim/CHANGELOG.md @@ -15,6 +15,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). ### Fixed - Import HAR entry sent and elapsed time. +- Duplicate or missing "Save URLs..." entries in the Export menu. +- The "Save All URLs..." export option was saving only the selected URLs. ## [0.12.0] - 2024-10-07 ### Changed diff --git a/addOns/exim/src/main/java/org/zaproxy/addon/exim/ExtensionExim.java b/addOns/exim/src/main/java/org/zaproxy/addon/exim/ExtensionExim.java index 1b8998bd5d..ce31a05aeb 100644 --- a/addOns/exim/src/main/java/org/zaproxy/addon/exim/ExtensionExim.java +++ b/addOns/exim/src/main/java/org/zaproxy/addon/exim/ExtensionExim.java @@ -56,9 +56,6 @@ public class ExtensionExim extends ExtensionAdaptor { private PopupMenuExportMessages popupMenuExportResponses; private PopupMenuExportMessages popupMenuExportMessages; - private PopupMenuExportContextUrls popupMenuExportContextUrls; - private PopupMenuExportSelectedUrls popupMenuExportSelectedrls; - private PopupMenuExportUrls popupMenuExportUrls; private PopupMenuCopyUrls popupMenuCopyUrls; public ExtensionExim() { @@ -98,14 +95,39 @@ public void hook(ExtensionHook extensionHook) { getMenuExport().add(getPopupMenuExportResponses()); } - extensionHook.getHookMenu().addPopupMenuItem(getPopupMenuExportContextUrls()); - getMenuExport().add(getPopupMenuExportContextUrls()); - - extensionHook.getHookMenu().addPopupMenuItem(getPopupMenuExportSelectedUrls()); - getMenuExport().add(getPopupMenuExportSelectedUrls()); - - extensionHook.getHookMenu().addPopupMenuItem(getPopupMenuExportUrls()); - getMenuExport().add(getPopupMenuExportUrls()); + extensionHook + .getHookMenu() + .addPopupMenuItem( + new PopupMenuExportContextUrls( + Constant.messages.getString("exim.menu.export.saveurls"), + this)); + getMenuExport() + .add( + new PopupMenuExportContextUrls( + Constant.messages.getString("exim.menu.export.context.urls"), + this)); + + extensionHook + .getHookMenu() + .addPopupMenuItem( + new PopupMenuExportSelectedUrls( + Constant.messages.getString("exim.menu.export.saveurls"), + this)); + getMenuExport() + .add( + new PopupMenuExportSelectedUrls( + Constant.messages.getString("exim.menu.export.popup.selected"), + this)); + + extensionHook + .getHookMenu() + .addPopupMenuItem( + new PopupMenuExportUrls( + Constant.messages.getString("exim.menu.export.popup"), this)); + getMenuExport() + .add( + new PopupMenuExportUrls( + Constant.messages.getString("exim.menu.export.popup"), this)); extensionHook.getHookMenu().addPopupMenuItem(getPopupMenuCopyUrls()); @@ -204,33 +226,6 @@ private PopupMenuExportMessages getPopupMenuExportResponses() { return popupMenuExportResponses; } - private PopupMenuExportContextUrls getPopupMenuExportContextUrls() { - if (popupMenuExportContextUrls == null) { - popupMenuExportContextUrls = - new PopupMenuExportContextUrls( - Constant.messages.getString("exim.menu.export.context.urls"), this); - } - return popupMenuExportContextUrls; - } - - private PopupMenuExportSelectedUrls getPopupMenuExportSelectedUrls() { - if (popupMenuExportSelectedrls == null) { - popupMenuExportSelectedrls = - new PopupMenuExportSelectedUrls( - Constant.messages.getString("exim.menu.export.popup.selected"), this); - } - return popupMenuExportSelectedrls; - } - - private PopupMenuExportUrls getPopupMenuExportUrls() { - if (popupMenuExportUrls == null) { - popupMenuExportUrls = - new PopupMenuExportSelectedUrls( - Constant.messages.getString("exim.menu.export.popup"), this); - } - return popupMenuExportUrls; - } - private PopupMenuCopyUrls getPopupMenuCopyUrls() { if (popupMenuCopyUrls == null) { popupMenuCopyUrls = diff --git a/addOns/exim/src/main/javahelp/help/contents/exim.html b/addOns/exim/src/main/javahelp/help/contents/exim.html index 37de6af130..ff6a3967ee 100644 --- a/addOns/exim/src/main/javahelp/help/contents/exim.html +++ b/addOns/exim/src/main/javahelp/help/contents/exim.html @@ -64,16 +64,16 @@