Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ascanrules: More example alerts #5706

Merged
merged 1 commit into from
Sep 18, 2024
Merged

ascanrules: More example alerts #5706

merged 1 commit into from
Sep 18, 2024

Conversation

kingthorin
Copy link
Member

Overview

  • Scan Rules > Added example alert handling.
  • Unit Tests > Added tests for the example alerts and references.
  • CHANGELOG > Added change note.

Related Issues

Checklist

  • [na] Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • Write tests
  • Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@thc202 thc202 mentioned this pull request Sep 16, 2024
Open
3 tasks
@thc202
Copy link
Member

thc202 commented Sep 16, 2024

This has conflicts.

@kingthorin
Copy link
Member Author

Otherwise good?

@thc202
Copy link
Member

thc202 commented Sep 16, 2024

Yes.

@kingthorin
Copy link
Member Author

Deconflicted

@kingthorin
ascanrules: More example alerts
1151ac2 
- Scan Rules > Added example alert handling.
- Unit Tests > Added tests for the example alerts and references.
- CHANGELOG > Added change note.

Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
@kingthorin
Copy link
Member Author

Changelog entries combined

@thc202
Copy link
Member

thc202 commented Sep 18, 2024

Thank you!

@thc202 thc202 merged commit 234e3db into zaproxy:main Sep 18, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
@kingthorin kingthorin deleted the yet-moar-examples branch September 18, 2024 14:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thc202 thc202 thc202 approved these changes

@ricekot ricekot ricekot approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingthorin @thc202 @ricekot