support minimal (Linux) and full (Linux + Xen) imgs at the same time #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both images built for me. Still need testing on HW. |
Should fix: #44 Renamed the images to better match their content/usage to name than before. Udpdated documentation to reflect the actual content of the layer. For development, it's recommended to use the -full image. The -minimal image might still be useful later on, for demonstration purposes, or perhaps for Linux upstreaming process as well. xen recipes must be moved to dynamic-layers, to allow for building without meta-virtualization enabled. Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
macpijan
force-pushed
the
images-fixes
branch
from
d935082 to
4115aca
Compare
macpijan
requested review from
m-iwanicki,
SergiiDmytruk and
krystian-hebel
and removed request for
m-iwanicki
|
On UEFI I'm getting: instead of the normal output of |
macpijan
force-pushed
the
images-fixes
branch
from
bcc8ec0 to
edf24b5
Compare
Builtin modules used in legacy build: https://github.com/zarhus/poky/blob/wic-plugin-pcbios-grub/scripts/lib/wic/plugins/source/bootimg-pcbios.py#L39 Modules: vga, biosdisk have not been present in the EFI build and could not be included. Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
macpijan
force-pushed
the
images-fixes
branch
from
edf24b5 to
543a022
Compare
I can imagine 543a022 might help here (not tested yet) |
|
I got an offline confirmation from @krystian-hebel that this has worked on HW, so I will go ahead and merge it if I manage to resolve the remaining suggestions. |
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support minimal (Linux) and full (Linux + Xen) imgs at the same time
Should fix: #44
Renamed the images to better match their content/usage to name than
before.
Udpdated documentation to reflect the actual content of the layer.
For development, it's recommended to use the -full image.
The -minimal image might still be useful later on, for demonstration
purposes, or perhaps for Linux upstreaming process as well.
xen recipes must be moved to dynamic-layers, to allow for building
without meta-virtualization enabled.