From 8f6f7d994cb90e2d5341953352868ddb2a4145ba Mon Sep 17 00:00:00 2001 From: John Kirkham Date: Wed, 31 Oct 2018 12:52:36 -0400 Subject: [PATCH 1/3] Drop Python 3.4 As we have already dropped Python 3.4 support in Zarr and we are about to add Python 3.7 support here, go ahead and drop Python 3.4 support in Numcodecs as well. --- .travis.yml | 1 - appveyor.yml | 7 ------- docs/contributing.rst | 4 ++-- setup.py | 1 - tox.ini | 6 +++--- 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/.travis.yml b/.travis.yml index 886ea772..1afe9443 100644 --- a/.travis.yml +++ b/.travis.yml @@ -13,7 +13,6 @@ addons: python: - 2.7 - - 3.4 - 3.5 - 3.6 diff --git a/appveyor.yml b/appveyor.yml index 59f45c36..13b7e196 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -19,13 +19,6 @@ environment: PYTHON_VERSION: "2.7" DISTUTILS_USE_SDK: "1" - - PYTHON: "C:\\Python34" - PYTHON_VERSION: "3.4" - - - PYTHON: "C:\\Python34-x64" - PYTHON_VERSION: "3.4" - DISTUTILS_USE_SDK: "1" - - PYTHON: "C:\\Python35" PYTHON_VERSION: "3.5" diff --git a/docs/contributing.rst b/docs/contributing.rst index 782f48d4..a95c18c0 100644 --- a/docs/contributing.rst +++ b/docs/contributing.rst @@ -145,9 +145,9 @@ To also run the doctests within docstrings, run:: Tests can be run under different Python versions using tox. E.g. (assuming you have the corresponding Python interpreters installed on your system):: - $ tox -e py27,py34,py35,py36 + $ tox -e py27,py35,py36 -NumCodecs currently supports Python 2.7 and Python 3.4-3.6, so the above command must +NumCodecs currently supports Python 2.7 and Python 3.5-3.6, so the above command must succeed before code can be accepted into the main code base. Note that only the py36 tox environment runs the doctests, i.e., doctests only need to succeed under Python 3.6. diff --git a/setup.py b/setup.py index bb49d588..c605c7db 100644 --- a/setup.py +++ b/setup.py @@ -339,7 +339,6 @@ def run_setup(with_extensions): 'Programming Language :: Python :: 2', 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', - 'Programming Language :: Python :: 3.4', 'Programming Language :: Python :: 3.5', ], author='Alistair Miles', diff --git a/tox.ini b/tox.ini index ea02dcfa..c8ac9b29 100644 --- a/tox.ini +++ b/tox.ini @@ -4,17 +4,17 @@ # and then run "tox" from this directory. [tox] -envlist = py27, py34, py35, py36, docs +envlist = py27, py35, py36, docs [testenv] setenv = PYTHONHASHSEED = 42 # hooks for coverage exclusions based on Python major version - py34,py35,py36: PY_MAJOR_VERSION = py3 + py35,py36: PY_MAJOR_VERSION = py3 py27: PY_MAJOR_VERSION = py2 commands = python setup.py build_ext --inplace - py27,py34,py35: pytest -v --cov=numcodecs numcodecs + py27,py35: pytest -v --cov=numcodecs numcodecs py36: pytest -v --cov=numcodecs --doctest-modules --doctest-glob=*.pyx numcodecs coverage report -m py36: flake8 --max-line-length=100 numcodecs From bac660e13c15398df3c061bfe9da1ad14fc5f0b3 Mon Sep 17 00:00:00 2001 From: John Kirkham Date: Wed, 31 Oct 2018 12:54:57 -0400 Subject: [PATCH 2/3] Note Python 3.6 in `setup.py` Adds Python 3.6 to the trove classifiers. It was already supported, but got missed in this list. So go ahead and add it. --- setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.py b/setup.py index c605c7db..563a1f5c 100644 --- a/setup.py +++ b/setup.py @@ -340,6 +340,7 @@ def run_setup(with_extensions): 'Programming Language :: Python :: 2.7', 'Programming Language :: Python :: 3', 'Programming Language :: Python :: 3.5', + 'Programming Language :: Python :: 3.6', ], author='Alistair Miles', author_email='alimanfoo@googlemail.com', From 75d6f55f75b219239b46275963ec30bc5ec13f70 Mon Sep 17 00:00:00 2001 From: John Kirkham Date: Wed, 31 Oct 2018 12:56:18 -0400 Subject: [PATCH 3/3] Note Python 3.4 support dropped in 0.6.0 Add this to the changelog since it is user facing. Though probably does not effect that many users at this point. --- docs/release.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/release.rst b/docs/release.rst index b22190ee..e3e4ed62 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -18,6 +18,8 @@ Release notes * Updated the msgpack dependency (by :user:`Jerome Kelleher `; :issue:`74`, :issue:`75`). +* Drop Python 3.4 (by :user:`John Kirkham `; :issue:`89`). + .. _release_0.5.5: 0.5.5