Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crc32c codec #610

Closed
dstansby opened this issue Oct 18, 2024 · 3 comments · Fixed by #613
Closed

Add crc32c codec #610

dstansby opened this issue Oct 18, 2024 · 3 comments · Fixed by #613
Labels
New codec Suggestion for a new codec

Comments

@dstansby
Copy link
Contributor

There's a request to add crc32c as a codec here, so zarr-python v3 can use it for sharding. I'm not entirely sure on the details, so someone more familiar might want to add a more in depth comment about this. More context at zarr-developers/zarr-python#2391

@normanrz
Copy link
Member

Would we just declare crc32c as a dep here or compile the code within numcodecs?

@dstansby
Copy link
Contributor Author

I'm pro adding it as a dependncy (and adding a corresponding Codec class for it)

@normanrz
Copy link
Member

Should the codec append a checksum, as it does in zarr-python right now, or just compute the checksum (hard to decode, though)?

@normanrz normanrz mentioned this issue Oct 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New codec Suggestion for a new codec
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants