Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ruff/flake8-pytest-style preview rules (PT) #606

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Oct 15, 2024

TODO:

  • Unit tests and/or doctests in docstrings
  • Tests pass locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • Docs build locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Codecov passes)

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (fed46e5) to head (445bcc0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #606   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2328     2328           
=======================================
  Hits         2326     2326           
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/tests/test_entrypoints.py 100.00% <100.00%> (ø)
numcodecs/tests/test_pcodec.py 100.00% <100.00%> (ø)
numcodecs/tests/test_shuffle.py 100.00% <100.00%> (ø)

Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 when the merge conflict is fixed

@dstansby dstansby enabled auto-merge (squash) October 20, 2024 08:46
PT001 Use `@pytest.fixture` over `@pytest.fixture()`
auto-merge was automatically disabled October 20, 2024 09:52

Head branch was pushed to by a user without write access

PT012 `pytest.raises()` block should contain a single simple statement
@dstansby dstansby merged commit 3da098b into zarr-developers:main Oct 22, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants