Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove v2 codebase #1898

Closed
wants to merge 1 commit into from
Closed

remove v2 codebase #1898

wants to merge 1 commit into from

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented May 21, 2024

Removes all the v2 code

supersedes #1897, #1791

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b d-v-b mentioned this pull request May 21, 2024
Closed
@d-v-b
Copy link
Contributor Author

d-v-b commented May 21, 2024

Since there are still valid uses of the v2 codebase in the v3 test suite, we should hold off on merging this until we are sure that we don't need v2 as a comparison point any more.

This was referenced May 24, 2024
Open
Closed
@jhamman jhamman closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @jhamman