Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix final typing errors #1939

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jun 1, 2024

This should fix the final typing errors. Fixes #1783

@@ -62,7 +62,7 @@ async def get(
path = _dereference_path(root, key)

try:
value = await (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not 100% correct but I think it can be fixed in #1785

@jhamman jhamman merged commit 19365e2 into zarr-developers:v3 Jun 1, 2024
18 checks passed
@dstansby dstansby deleted the final-typing branch June 2, 2024 10:45
d-v-b added a commit to d-v-b/zarr-python that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v3] Path to 100% typing
3 participants