Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package building #105

Merged
merged 7 commits into from
Aug 2, 2019
Merged

Debian package building #105

merged 7 commits into from
Aug 2, 2019

Conversation

ervanalb
Copy link
Collaborator

@ervanalb ervanalb commented Jul 30, 2019

This pull request migrates Travis to Bionic and gets it building a .deb file.
Once Debian packages are built by Travis, we can put them on a PPA through launchpad.

Related to #47 and #94

@ervanalb ervanalb requested a review from zbanks July 30, 2019 03:43
@ervanalb
Copy link
Collaborator Author

Also related to #94

@ervanalb ervanalb changed the title Debian package building (part 1) Debian package building Jul 31, 2019
@ervanalb ervanalb changed the title Debian package building Debian package building [do not merge yet] Jul 31, 2019
if [ -z "$4" ]; then
echo "You must specify a packaging version (e.g. 1) as the fourth argument" >&2
exit 1
fi
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if [ "$#" -ne 4 ]?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 or 5 arguments is OK

if [[ $TRAVIS_OS_NAME == 'osx' ]]
then
make bundle
elif [[ $TRAVIS_OS_NAME == 'linux' ]]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be pushed into the yml? on.condition: "$TRAVIS_OS_NAME == linux" or does that not work

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the pattern already in most of the travis scripts, I don't really feel like changing it. TBH I don't understand travis's yml.

Fix paths in travis
Pass in a version to build
add -e flag to all scripts
fix syntax, add doxygen
fix path passed to debian.sh
Add devscripts to travis for debian building
Add fakeroot and attempt to deploy the artifact
Default to 0~dev0 if no tag is present, and deploy the correct artifact (maybe)
Fix some paths, maybe
Flip conditional
Add graphviz to dependencies for doxygen
@ervanalb ervanalb changed the title Debian package building [do not merge yet] Debian package building Jul 31, 2019
@zbanks zbanks merged commit 936ddc1 into master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants