-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basedpyright extension #1080
Conversation
m1guer
commented
Jul 17, 2024
•
edited
Loading
edited
- fix the schemas.
We require contributors to sign our Contributor License Agreement, and we don't have @m1guer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@maxdeviant any update on this review? |
+1 |
Thank you! I'd love to give this a try. CI has started. |
why everytime give this error...? |
@rgbkrk can you check for me pls? |
In https://github.com/m1guer/basedpyright-zed/blob/main/extension.toml, change |
oh, nice fixed! try now. |
You'll have to bump the submodule to point to your newest commit in that repo. |
maybe i dont have the capabilities to do that. |
lets see if works now. |
yayyyy |
- [x] fix the schemas.