Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basedpyright extension #1080

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Add basedpyright extension #1080

merged 9 commits into from
Jul 30, 2024

Conversation

m1guer
Copy link
Contributor

@m1guer m1guer commented Jul 17, 2024

  • fix the schemas.

Copy link

cla-bot bot commented Jul 17, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @m1guer on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@m1guer
Copy link
Contributor Author

m1guer commented Jul 17, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jul 17, 2024
Copy link

cla-bot bot commented Jul 17, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant changed the title feat(lsp):add basedpyright lsp for python dev Add basedpyright extension Jul 18, 2024
@m1guer
Copy link
Contributor Author

m1guer commented Jul 23, 2024

@maxdeviant any update on this review?

@failable
Copy link

+1

@rgbkrk
Copy link
Member

rgbkrk commented Jul 29, 2024

Thank you! I'd love to give this a try. CI has started.

@m1guer
Copy link
Contributor Author

m1guer commented Jul 29, 2024

why everytime give this error...?

@m1guer
Copy link
Contributor Author

m1guer commented Jul 29, 2024

@rgbkrk can you check for me pls?

@rgbkrk
Copy link
Member

rgbkrk commented Jul 29, 2024

In https://github.com/m1guer/basedpyright-zed/blob/main/extension.toml, change id = "python" to id = "basedpyright".

@m1guer
Copy link
Contributor Author

m1guer commented Jul 29, 2024

oh, nice fixed! try now.

@JosephTLyons
Copy link
Collaborator

You'll have to bump the submodule to point to your newest commit in that repo.

@m1guer
Copy link
Contributor Author

m1guer commented Jul 29, 2024

maybe i dont have the capabilities to do that.

@m1guer
Copy link
Contributor Author

m1guer commented Jul 29, 2024

lets see if works now.

@m1guer
Copy link
Contributor Author

m1guer commented Jul 29, 2024

yayyyy

@rgbkrk rgbkrk merged commit ee5a078 into zed-industries:main Jul 30, 2024
2 checks passed
adorabilis pushed a commit to adorabilis/zed-extensions that referenced this pull request Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants