-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New python modules require editor restart #8960
Comments
Or restart LSP only. |
Potentially related #7296 |
In the past, I've made the assumption that this was just a pyright deficiency, but I'm going to throw this on the project board for next week's quality week and have someone more qualified than I see if there's anything we can do on our end - even if we need to put in a hack. |
This looks to be a Pyright issue indeed; we properly notify a language server about path changes, yet it doesn't react. |
Are you saying that new modules are being recognized, without restarting, while in debug mode? If there are no performance issues with it, I wonder if we can just stay in debug mode. Others may not agree, but I think I'm for putting in a hack here to get this to work, since I hope to be rid of Pyright somewhere down the line anyway. That being said, the issue with relying on some weird side effect is that it might go away at any moment. |
Yeah, it seems like it does in fact work. We do notify the language server properly of changes in the local worktree, and with pyright.json config file, dependency installation is handled just fine as well. Please do reopen this issue if you run into it again. |
@osiewicz and I double checked and it seems like pyright is currently
The version of pyright listed in my Is anyone else able to reproduce the original issue here? Edit: sorry for repeating what Piotr said! |
Check for existing issues
Describe the bug / provide steps to reproduce it
When a new python file is created, I am unable to get the editor to recognize the module without restarting Zed.
This might have to do with Pyright, I am unsure.
Environment
Zed: v0.124.8 (Zed)
OS: macOS 14.3.1
Memory: 64 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
issue.mp4
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.If you only need the most recent lines, you can run the
zed: open log
command palette action to see the last 1000.No response
The text was updated successfully, but these errors were encountered: