-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search: Treat non-word char as whole-char when searching #19152
Merged
SomeoneToIgnore
merged 7 commits into
zed-industries:main
from
CharlesChen0823:search_fixed
Nov 28, 2024
Merged
search: Treat non-word char as whole-char when searching #19152
SomeoneToIgnore
merged 7 commits into
zed-industries:main
from
CharlesChen0823:search_fixed
Nov 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Oct 13, 2024
CharlesChen0823
changed the title
search: treat non-word char as whole-char when search
search: treating non-word char as whole-char when search
Oct 13, 2024
CharlesChen0823
changed the title
search: treating non-word char as whole-char when search
search: Treating non-word char as whole-char when search
Oct 13, 2024
maxdeviant
changed the title
search: Treating non-word char as whole-char when search
search: Treat non-word char as whole-char when searching
Oct 15, 2024
This needs a test and given #19958 (comment) it seems better to close this for now and revisit later. |
@SomeoneToIgnore please reopened it. |
SomeoneToIgnore
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when search somethings like
clone(
, with search optionsmatch case sensitively
andmatch whole words
in zed code base, onlyclone(cx)
hit match,clone()
will not hit math.Release Notes: