Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search: Treat non-word char as whole-char when searching #19152

Merged
merged 7 commits into from
Nov 28, 2024

Conversation

CharlesChen0823
Copy link
Contributor

@CharlesChen0823 CharlesChen0823 commented Oct 13, 2024

when search somethings like clone(, with search options match case sensitively and match whole words in zed code base, only clone(cx) hit match, clone() will not hit math.

Release Notes:

  • Improved buffer search for queries ending with non-letter characters

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 13, 2024
@CharlesChen0823 CharlesChen0823 changed the title search: treat non-word char as whole-char when search search: treating non-word char as whole-char when search Oct 13, 2024
@CharlesChen0823 CharlesChen0823 changed the title search: treating non-word char as whole-char when search search: Treating non-word char as whole-char when search Oct 13, 2024
@maxdeviant maxdeviant changed the title search: Treating non-word char as whole-char when search search: Treat non-word char as whole-char when searching Oct 15, 2024
@SomeoneToIgnore
Copy link
Contributor

This needs a test and given #19958 (comment) it seems better to close this for now and revisit later.

@CharlesChen0823
Copy link
Contributor Author

@SomeoneToIgnore please reopened it.

@SomeoneToIgnore SomeoneToIgnore marked this pull request as draft November 27, 2024 06:15
@CharlesChen0823 CharlesChen0823 marked this pull request as ready for review November 27, 2024 08:51
Copy link
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@SomeoneToIgnore SomeoneToIgnore merged commit cacec06 into zed-industries:main Nov 28, 2024
13 checks passed
@CharlesChen0823 CharlesChen0823 deleted the search_fixed branch December 2, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants