gpui: Add transition animations #25602
Open
+257
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
someone13574
commented
Feb 26, 2025
| @@ -54,15 +56,33 @@ impl Render for AnimationExample { | |||
| .size_8() | |||
| .path(ARROW_CIRCLE_SVG) | |||
| .text_color(black()) | |||
| .id("svg") | |||
| .on_mouse_move(|_, _, _| {}) | |||
There was a problem hiding this comment.
Unrelated question: Does anyone know why I need another event handler for the on_hover to receive events? Is this intended?
someone13574
force-pushed
the
animate-when
branch
from
862fc3a to
03665ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds animations which provide an animation closure for interpolating between boolean states, mirroring the
.when()and animation API's. This makes animations like hovers a lot easier.I also implemented the
StyledandInteractiveElementtraits forAnimationElementandTransitionElementifEimplements them, so that it is a bit easier to use wrapped elements.Here is the updated animation example showing how easing and different forward/backward durations can be used:
2025-02-25.17-20-15.mp4
Release Notes: