-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assistant: Improve Amazon Bedrock configuration instructions #25699
base: main
Are you sure you want to change the base?
Conversation
@5herlocked Could you please include a screenshot of the changes? |
Oops, hadn't seen this before I opened #25745 — also touched on this there! ![]() I like your changes, and mine are also hopefully an improvement, but I'm feeling like the ultimate/best fix for this is figuring out a more classic, web-like input component with label, input, and placeholder. |
So long-term, we would actually prefer if the user never have to use this. But I love your changes because it makes it feel a lot more "cozy" |
# Conflicts: # crates/language_models/src/provider/bedrock.rs
Yeah definitely good shout -- If we want to actually have an exact number of Placeholder 'X's - Access Key Id is usually around 16 characters and Secret Access Key is around 40 characters. If we wanted validation down the line -- https://github.com/awslabs/git-secrets/blob/5357e18bc27b42a827b6780564ea873a72ca1f01/git-secrets#L234 which also contains AWS approved examples for AAID and SK's |
Based on question, discussion here -- #16544 (comment)
Plus the fact that it wasn't clear to anyone who isn't familiar with AWS, updating the UX to more friendly and guided.
Release Notes: