cli: Add extra paths in detect() on Windows
#25765
Open
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
maxdeviant
changed the title
detect() on Windows
ognevny
force-pushed
the
cli-windows-detect
branch
from
a84212c to
15e0e64
Compare
|
and yeah, thank you, @JunkuiZhang, for making CLI work on Windows :) |
ognevny
force-pushed
the
cli-windows-detect
branch
from
15e0e64 to
901bb86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm already integrating CLI into MSYS2 package, and this patche helped me to make it work like in Arch: msys2/MINGW-packages#23537. used the same way as in Linux implementation
Closes #ISSUE
Release Notes: