Skip to content

Revert "Keep selection in SwitchToHelixNormalMode (#41583)" #42892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2025
Merged

Revert "Keep selection in SwitchToHelixNormalMode (#41583)" #42892

merged 4 commits into from
Nov 17, 2025

Conversation

@ConradIrwin
Copy link
Member

@ConradIrwin ConradIrwin commented Nov 17, 2025

Closes #ISSUE

Release Notes:

  • Fixes vim "go to definition" making a selection

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 17, 2025
@ConradIrwin
Copy link
Member Author

ConradIrwin commented Nov 17, 2025

/cherry-pick preview

@ConradIrwin ConradIrwin merged commit 6bf5e92 into main Nov 17, 2025
23 checks passed
@ConradIrwin ConradIrwin deleted the vim-gtd branch November 17, 2025 18:01
github-actions bot pushed a commit that referenced this pull request Nov 17, 2025
@ConradIrwin
Revert "Keep selection in SwitchToHelixNormalMode (#41583)" (#42892)
38ff491 
Closes #ISSUE

Release Notes:

- Fixes vim "go to definition" making a selection
@zed-zippy zed-zippy bot mentioned this pull request Nov 17, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 17, 2025
@ConradIrwin
Revert "Keep selection in SwitchToHelixNormalMode (#41583)" (#42892)
37c067e 
Closes #ISSUE

Release Notes:

- Fixes vim "go to definition" making a selection
@zed-zippy
Copy link

zed-zippy bot commented Nov 17, 2025

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/19439503685

@ConradIrwin ConradIrwin mentioned this pull request Nov 17, 2025
Closed
zed-zippy bot added a commit that referenced this pull request Nov 17, 2025
@zed-zippy @ConradIrwin
Revert "Keep selection in SwitchToHelixNormalMode (#41583)" (#42892)…
49e1e84 
… (cherry-pick to preview) (#42903)

Cherry-pick of #42892 to preview

----
Closes #ISSUE

Release Notes:

- Fixes vim "go to definition" making a selection

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
@HactarCE HactarCE mentioned this pull request Nov 17, 2025
Merged
HactarCE added a commit that referenced this pull request Nov 19, 2025
@HactarCE @ConradIrwin
Fix Helix mode search & selection (#42928)
27cb01f 
This PR redoes the desired behavior changes of #41583 (reverted in
#42892) but less invasively

Closes #41125
Closes #41164

Release Notes:

- N/A

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
mikayla-maki pushed a commit that referenced this pull request Nov 20, 2025
@HactarCE @ConradIrwin @mikayla-maki
Fix Helix mode search & selection (#42928)
85d4296 
This PR redoes the desired behavior changes of #41583 (reverted in
#42892) but less invasively

Closes #41125
Closes #41164

Release Notes:

- N/A

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ConradIrwin