Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask-uwsgi-websocket middlewares violate PEP-333 #78

Open
ergoithz opened this issue Dec 9, 2019 · 0 comments
Open

flask-uwsgi-websocket middlewares violate PEP-333 #78

ergoithz opened this issue Dec 9, 2019 · 0 comments

Comments

@ergoithz
Copy link

ergoithz commented Dec 9, 2019

This module is not WSGI compliant. PEP-333 rules start_response callable must be called before wsgi app returns (or starts yielding), and here it isn't for websocket requests, which could make other wsgi middlewares (or any compliant wsgi server) to raise.

handler(self.client(environ, uwsgi.connection_fd(), self.websocket.timeout), **args)
return []

@ergoithz ergoithz changed the title flask-uwsgi-websocket middlewares violates PEP-333 flask-uwsgi-websocket middlewares violate PEP-333 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant