[Kineto Register] Improve the kineto profiler factory register method without the instantiation of LibkinetoApi singleton instance #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of factory and the instantiation of the singleton LibkinetoApi. In this PR, we add a new register interface and a new container to save the registered factories. Those factories will be saved into the plugin::plugin_factories. The plugin::plugin_factories is outside of the singleton LibkinetoApi. Those factories will be called in initChildActivityProfilers to finish the registeration. Signed-off-by: Chen, Zejun <zejun.chen@intel.com>
zejun-chen
force-pushed
the
zejun/register_infra
branch
from
464402b to
4f5d0fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Kineto Register] Here this PR decouples the registration of factory and the instantiation of the singleton LibkinetoApi. In this PR, we add a new register interface and a new container to save the registered factories. Those factories will be saved into the plugin::plugin_factories. The plugin::plugin_factories is outside of the singleton LibkinetoApi. Those factories will be called in initChildActivityProfilers to finish the registeration.