From 61be9af66341dedbc5416a356de7a53e096b4e8d Mon Sep 17 00:00:00 2001 From: Ed Hanton Date: Wed, 31 Jan 2024 22:03:06 +0000 Subject: [PATCH 1/2] Comply zaf_sdk.min.js with requirements Updates webpack so that the zaf_sdk.js link complies with zendesk requirements --- packages/react/webpack.config.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/react/webpack.config.js b/packages/react/webpack.config.js index cff7446..74e905b 100644 --- a/packages/react/webpack.config.js +++ b/packages/react/webpack.config.js @@ -7,7 +7,7 @@ const TranslationsPlugin = require('./webpack/translations-plugin') const externalAssets = { js: [ - 'https://assets.zendesk.com/apps/sdk/2.0/zaf_sdk.js' + 'https://assets.zendesk.com/apps/sdk/2.0/zaf_sdk.min.js' ] } @@ -77,7 +77,15 @@ module.exports = { warning: 'AUTOMATICALLY GENERATED FROM ./src/templates/iframe.html - DO NOT MODIFY THIS FILE DIRECTLY', vendorJs: externalAssets.js, template: './src/templates/iframe.html', - filename: 'iframe.html' + filename: 'iframe.html', + minify: { + collapseWhitespace: true, + keepClosingSlash: true, + removeComments: true, + removeRedundantAttributes: false, + removeScriptTypeAttributes: false, + removeStyleLinkTypeAttributes: false, + } }) ] } From 37e52e0c52536a67830f6f0e4f4ce973fb03031f Mon Sep 17 00:00:00 2001 From: Ed Hanton Date: Wed, 31 Jan 2024 22:21:45 +0000 Subject: [PATCH 2/2] Update zaf_sdk.min.js location --- packages/react/webpack.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/webpack.config.js b/packages/react/webpack.config.js index 74e905b..3cd7c2c 100644 --- a/packages/react/webpack.config.js +++ b/packages/react/webpack.config.js @@ -7,7 +7,7 @@ const TranslationsPlugin = require('./webpack/translations-plugin') const externalAssets = { js: [ - 'https://assets.zendesk.com/apps/sdk/2.0/zaf_sdk.min.js' + 'https://static.zdassets.com/zendesk_app_framework_sdk/2.0/zaf_sdk.min.js' ] }