Skip to content

Commit

Permalink
fix(article): make "Was this article helpful?" h2
Browse files Browse the repository at this point in the history
Accessibility update
  • Loading branch information
EmmaEwert committed Aug 15, 2023
1 parent 93a6b03 commit d73f8d1
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 1 deletion.
4 changes: 4 additions & 0 deletions style.css
Original file line number Diff line number Diff line change
Expand Up @@ -1856,6 +1856,10 @@ ul {
padding: 30px 0;
text-align: center;
}
.article-votes-question {
font-size: 15px;
font-weight: normal;
}
.article-vote {
margin: 10px 5px;
min-width: 90px;
Expand Down
5 changes: 5 additions & 0 deletions styles/_article.scss
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,11 @@
border-top: 1px solid $low-contrast-border-color;
padding: 30px 0;
text-align: center;

&-question { // Explicit values for rendering h2 like a span
font-size: $font-size-base;
font-weight: normal;
}
}

&-vote {
Expand Down
2 changes: 1 addition & 1 deletion templates/article_page.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
</div>
{{#with article}}
<div class="article-votes">
<span class="article-votes-question" id="article-votes-label">{{t 'was_this_article_helpful'}}</span>
<h2 class="article-votes-question" id="article-votes-label">{{t 'was_this_article_helpful'}}</h2>
<div class="article-votes-controls" role="group" aria-labelledby="article-votes-label">
{{vote 'up' class='button article-vote article-vote-up' selected_class="button-primary"}}
{{vote 'down' class='button article-vote article-vote-down' selected_class="button-primary"}}
Expand Down

0 comments on commit d73f8d1

Please sign in to comment.