Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebased v4-alpha branch on top of master #408

Closed
wants to merge 81 commits into from
Closed

Rebased v4-alpha branch on top of master #408

wants to merge 81 commits into from

Conversation

luis-almeida
Copy link
Contributor

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

albertfdp and others added 30 commits July 13, 2023 14:59
@albertfdp
fix: aria-expanded should be on the button
8df6493
@albertfdp
refactor: align Dropdown with navigation menubar spec
915a5fb
@albertfdp
feat: set tabindex to menuitems
833b13c
@albertfdp
refactor: move outside click handler to Dropdown
82b4c97
@albertfdp
feat: align with garden styles
610cf69
@albertfdp
fix: show ellipsis in sidebar for very long titles
a685729
@albertfdp
fix: show ellipsis for very long article titles
916db29
@albertfdp
fix: show ellipsis for section titles
71efc13
@albertfdp
chore: build styles
c113cf9
@albertfdp
fix: move for mobile
a11089c
@albertfdp
feat: also support menuitemradio
a1102d1
@albertfdp
refactor: switch to menuitemradio role
0491cda
@albertfdp
chore: add jest and @testing-library/dom setup
adbccff
@albertfdp
test: dropdown attributes
73a3710
@albertfdp
test: target keydown handler
67ce4ee
@albertfdp
test: menu keyboard events
462c979
@albertfdp
test: outside click
d0ca51b
@albertfdp
test: shift+tab on menu
ecf0391
@albertfdp
test: ignored key shortcuts
7ec4603
@albertfdp
chore: add testing to gh actions
3dd7a42
@albertfdp
chore: fix linting
f2cc8da
@albertfdp
chore: build
e3c6fd5
@albertfdp
Merge pull request #386 from zendesk/afernandez/article-title
0dc3db5 
fix: ellipsis for very long titles
@zd-svc-github-copenhagen-theme
chore(release): 3.0.6
4d81b1e 
## [3.0.6](v3.0.5...v3.0.6) (2023-07-19)

### Bug Fixes

* move for mobile ([a11089c](a11089c))
* show ellipsis for section titles ([71efc13](71efc13))
* show ellipsis for very long article titles ([916db29](916db29))
* show ellipsis in sidebar for very long titles ([a685729](a685729))
@albertfdp
Merge branch 'master' into afernandez/OH-2227
1173bcd
@albertfdp
chore: collocate test next to the tested component
905a5bf
@luis-almeida
Merge pull request #388 from zendesk/afernandez/OH-2227
188df1b 
a11y: Dropdowns
@zd-svc-github-copenhagen-theme
chore(release): 3.1.0
e951460 
# [3.1.0](v3.0.6...v3.1.0) (2023-07-19)

### Bug Fixes

* aria-expanded should be on the button ([8df6493](8df6493))

### Features

* align with garden styles ([610cf69](610cf69))
* also support menuitemradio ([a1102d1](a1102d1))
* set tabindex to menuitems ([833b13c](833b13c))
@smansouri
Revert "Remove aria-expanded attribute from section tag in search res…
5fc6c2f 
…ult page"
@smansouri
Merge pull request #398 from zendesk/revert-376-smansouri.remove-aria…
0a2b26e 
…-expanded-from-section

Revert "Remove aria-expanded attribute from section tag in search result page"
luis-almeida and others added 27 commits August 9, 2023 12:08
@luis-almeida
chore: ignore assets/ apart from release
fa7fa59
@luis-almeida
chore: import from sourcemap indentifier
198bae0
@luis-almeida
chore: upgrade zcli to latest version
1902287
@Fredx87 @luis-almeida
chore: added TypeScript support to Rollup
0df93bd
@Fredx87 @luis-almeida
refactor: splitted New Request Form implementation in multiple files
f701ebd
@Fredx87 @luis-almeida
chore: setup TypeScript integration for ESLint
f04b671
@Fredx87 @luis-almeida
chore: stricter TS config
bc0d79e
@Fredx87 @luis-almeida
chore: fixed react eslint configuration
95f2dd2
@Fredx87 @luis-almeida
chore: simplified TS setup
806f3f1
@Fredx87 @luis-almeida
chore: refactored new-request-form module folder structure
522b88b
@Fredx87 @luis-almeida
chore: added plugin for automatic importmap generation
22052d1
@Fredx87 @luis-almeida
chore: minor improvements for import map plugin
a413c32
@Fredx87 @luis-almeida
feat: added Garden subject field in new request form
32df3ee
@luis-almeida
chore: hide generated files instead of ignoring
be242b5
@luis-almeida
fix: request_form has been renamed to new_request_form
1a3578a
@luis-almeida
feat: handling priority field
88d82aa
@luis-almeida
feat: handling textarea fields
7c3f4ff
@luis-almeida
feat: handling anonymous_requester_email field
cae0ff0
@luis-almeida
chore: address "this" has been rewritten to "undefined" warning
1607a84
@luis-almeida
chore: built assets
6ee8eab
@luis-almeida
refactor: applying PR feedback
7d9fe3c
@Fredx87 @luis-almeida
refactor: use json serialized data
0e7a6af
@Fredx87 @luis-almeida
feat: improved Ticket Form selector
43d7f4b
@Fredx87 @luis-almeida
feat: added form submission and global form errors handling
e24287f
@Fredx87 @luis-almeida
chore: renamed StyledForm to Form
4786978
@Fredx87 @luis-almeida
feat: added useSubmitHandler hook
f01eca7
@luis-almeida
fix: correct rebase mistake
6396a5c
@luis-almeida luis-almeida requested a review from a team as a code owner August 9, 2023 10:30
@luis-almeida luis-almeida deleted the luis.v4-alpha-rebased branch August 9, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@luis-almeida @albertfdp @zd-svc-github-copenhagen-theme @smansouri @Fredx87 @anpa @anialesniak @sergioazevedo