Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Make "Was this article helpful?" a h2 #415

Merged
merged 1 commit into from
Aug 25, 2023
Merged

[A11y] Make "Was this article helpful?" a h2 #415

merged 1 commit into from
Aug 25, 2023

Conversation

EmmaEwert
Copy link
Contributor

@EmmaEwert EmmaEwert commented Aug 15, 2023 •
edited
Loading

Description

When a page uses heading markup that does not match the information communicated visually by the heading screen reader users may not understand the content of the page.

This PR changes the span tag for the "Was this article helpful?" string to an h2 tag, as well as the styling required to make this change seamless.

Checklist

  • 📗 all commit messages follow the conventional commits standard
  • ⬅️ changes are compatible with RTL direction
  • ♿ Changes to the UI are tested for accessibility and compliant with WCAG 2.1.
  • 📝 changes are tested in Chrome, Firefox, Safari and Edge
  • 📱 changes are responsive and tested in mobile
  • 👍 PR is approved by @zendesk/vikings

@EmmaEwert EmmaEwert force-pushed the emma/votes-question-heading-level branch 4 times, most recently from d73f8d1 to 5a4505d Compare August 21, 2023 12:10
@EmmaEwert EmmaEwert force-pushed the emma/votes-question-heading-level branch from 5a4505d to bb5db8f Compare August 22, 2023 12:34
@EmmaEwert EmmaEwert requested a review from a team August 22, 2023 12:41
@EmmaEwert EmmaEwert marked this pull request as ready for review August 22, 2023 12:41
@EmmaEwert EmmaEwert requested a review from a team as a code owner August 22, 2023 12:41
@EmmaEwert EmmaEwert merged commit 180a5aa into master Aug 25, 2023
6 checks passed
@EmmaEwert EmmaEwert deleted the emma/votes-question-heading-level branch August 25, 2023 07:48
@zd-svc-github-copenhagen-theme
Copy link
Collaborator

🎉 This PR is included in version 3.1.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergioazevedo sergioazevedo sergioazevedo approved these changes

@st33n st33n st33n approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmaEwert @zd-svc-github-copenhagen-theme @st33n @sergioazevedo