chore: linting fixes and improvements #426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luis-almeida
force-pushed
the
luis.eslint_fixes
branch
from
830ecf2
to
1b861de
Compare
Fredx87
reviewed
Sep 4, 2023
There was a problem hiding this comment.
In this PR I'm also adding ls-lint to check for file and folder name patterns. There may be better tools so feel free to add feedback.
It seems that there are also some eslint plugins that are able to perform the same checks, like https://github.com/DukeLuo/eslint-plugin-check-file. I don't know if they are as powerful as ls-lint, I am ok to use ls-lint as well
luis-almeida
force-pushed
the
luis.eslint_fixes
branch
from
1b861de
to
6e59ddc
Compare
luis-almeida
force-pushed
the
luis.eslint_fixes
branch
from
6e59ddc
to
8a136c8
Compare
6 tasks
|
I have opened a PR using https://github.com/DukeLuo/eslint-plugin-check-file with an alternative approach: #427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have just realised that we were only running the
checksworkflow on PRs againstmaster.This means that our all the PRs on
v4-alphawere unchecked. In this PR I editing the action so checks run on PRs against all branches.Keeping consistency around file/folder naming, app structure or export/import patterns is hard.
In this PR I'm also adding
ls-lintto check for file and folder name patterns. There may be better tools so feel free to add feedback.Checklist