chore: linting fixes and improvements #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
luis-almeida
commented
Sep 5, 2023
| "check-file/filename-naming-convention": [ | ||
| "error", | ||
| { | ||
| "src/**/*.{js,ts,tsx}": `@(${CAMEL_CASE}|${PASCAL_CASE})`, |
There was a problem hiding this comment.
Unfortunately this is the only way to support multiple pattern per file name: dukeluo/eslint-plugin-check-file#28 (comment)
I converted the file to js so we could at least name the variables but we can always inline the regex and keep it .eslintrc.json
sergioazevedo
approved these changes
Sep 5, 2023
Fredx87
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have just realised that we were only running the
checksworkflow on PRs againstmaster.This means that our all the PRs on
v4-alphawere unchecked. In this PR I editing the action so checks run on PRs against all branches.Keeping consistency around file/folder naming, app structure or export/import patterns is hard.
In this PR I'm also adding bringing in
eslint-plugin-check-fileto check for file and folder name patterns. This is an alternative approach to usingls-linttried in #426.Screenshots
Checklist