Skip to content

fix: updates constant imports in grid story and lingering dropdowns.next references #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

fix: updates constant imports in grid story and lingering dropdowns.next references #1727

merged 2 commits into from
Feb 29, 2024

Conversation

@geotrev
Copy link
Contributor

@geotrev geotrev commented Feb 29, 2024

Description

Missing renamed import corrections.

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@geotrev geotrev self-assigned this Feb 29, 2024
@geotrev geotrev requested a review from a team as a code owner February 29, 2024 14:58
jzempel
jzempel requested changes Feb 29, 2024
View reviewed changes
packages/dropdowns.legacy/demo/autocomplete.stories.mdx Outdated

**DEPRECATED:** use `@zendeskgarden/react-dropdowns.next`
**DEPRECATED:** use `@zendeskgarden/react-dropdowns`
[Combobox](https://zendeskgarden.github.io/react-components/?path=/docs/packages-dropdowns-next-combobox--docs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get these URLs fixed in prep for main? They'll be broken for now, but that's ok.

Copy link
Contributor Author

@geotrev geotrev Feb 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. Can do. I'll move these to a separate PR against main.

@coveralls
Copy link

coveralls commented Feb 29, 2024 •
edited
Loading

Coverage Status

coverage: 96.012%. remained the same
when pulling 5078e25 on george/export-fixes
into 7e58e69 on next.

@geotrev geotrev force-pushed the george/export-fixes branch from 6120bf3 to 1a93350 Compare February 29, 2024 15:50
@geotrev geotrev requested a review from jzempel February 29, 2024 15:55
@geotrev geotrev force-pushed the george/export-fixes branch from 1a93350 to 9ae9ccc Compare February 29, 2024 16:17
@geotrev geotrev changed the title fix: constant imports in grid story fix: updates constant imports in grid story and lingering dropdowns.next references Feb 29, 2024
@geotrev geotrev force-pushed the george/export-fixes branch from 9ae9ccc to 5078e25 Compare February 29, 2024 16:42
@geotrev geotrev merged commit c80c3ff into next Feb 29, 2024
@geotrev geotrev deleted the george/export-fixes branch February 29, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

Assignees

@geotrev geotrev

Labels

PR: Bug Fix 🐛

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@geotrev @coveralls @jzempel @zendesk-garden