Skip to content

feat: adds an internal getColorV8 utility #1754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2024
Merged

feat: adds an internal getColorV8 utility #1754

merged 3 commits into from
Mar 25, 2024

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Mar 22, 2024

Description

This PR lays the foundation to support staged package migration to v9 where this theming utility will function over the v8 color palette (and be marked as @deprecated).

@jzempel jzempel requested a review from a team as a code owner March 22, 2024 15:06
@coveralls
Copy link

Coverage Status

coverage: 96.194%. remained the same
when pulling dc4c594 on jzempel/v8-getcolor
into 5e8637f on main.

geotrev
geotrev approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@geotrev geotrev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⛏️

@jzempel jzempel merged commit f906ed4 into main Mar 25, 2024
@jzempel jzempel deleted the jzempel/v8-getcolor branch March 25, 2024 17:49
jzempel added a commit that referenced this pull request Mar 26, 2024
@jzempel
feat: adds an internal getColorV8 utility (#1754)
d1fbad8
jzempel added a commit that referenced this pull request Mar 26, 2024
@jzempel
chore(next): updates from main (#1757)
041ba94 
* chore(deps): bump follow-redirects (#1751)

* chore(deps-dev): bump webpack-dev-middleware from 6.1.1 to 6.1.2 (#1753)

* feat: adds an internal `getColorV8` utility (#1754)

* chore: remove all `colors.background` and `colors.foreground` theme references in prep for v9 (#1756)
@jzempel jzempel mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@geotrev geotrev geotrev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR: New Feature 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jzempel @coveralls @geotrev @zendesk-garden