Skip to content

Conversation

@geotrev
Copy link
Contributor

@geotrev geotrev commented Mar 26, 2024

Description

Removes toolbar control for strict mode, instead making it the default behavior. Sets framework.options.strictMode to true.

Detail

This PR depends on the following PR to add this feature:

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@geotrev geotrev self-assigned this Mar 26, 2024
@geotrev geotrev requested a review from a team as a code owner March 26, 2024 19:28
@geotrev geotrev marked this pull request as draft March 26, 2024 19:29
@geotrev geotrev force-pushed the george/sm-storybook branch from 995baf5 to 4e43f62 Compare March 26, 2024 20:05
@coveralls
Copy link

coveralls commented Mar 26, 2024

Coverage Status

coverage: 96.022%. remained the same
when pulling a4f430c on george/sm-storybook
into 6708d80 on next.

@geotrev geotrev force-pushed the george/sm-storybook branch from 4e43f62 to a4f430c Compare March 26, 2024 20:28
@geotrev geotrev changed the title WIP feat: use strict mode as storybook default feat: use strict mode as storybook default Mar 26, 2024
@geotrev geotrev marked this pull request as ready for review March 26, 2024 20:29
Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update and nice clean up! 💯

@geotrev geotrev merged commit 6263ced into next Mar 27, 2024
@geotrev geotrev deleted the george/sm-storybook branch March 27, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants