feat(chrome)!: detect Footer automatically with Context #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
force-pushed
the
george/chrome-body-footer
branch
from
4d9bfdf to
0b898b1
Compare
geotrev
changed the title
jzempel
reviewed
Mar 28, 2024
| #### @zendeskgarden/react-chrome | ||
|
|
||
| - Removed `PRODUCT` type export. Use `IHeaderItemProps['product']` instead. | ||
| - Removed `hasFooter` prop for `Body` (no replacement needed) |
There was a problem hiding this comment.
Should we call out that IBodyProps is no longer exported?
jzempel
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
hasFooterprop fromreact-chrome'sBodycomponent. Uses React context similar to how other components detect when a child is present in the JSX tree.Checklist
👌 design updates will be Garden Designer approved (add the designer as a reviewer)npm start)⬅️ renders as expected with reversed (RTL) direction🤘 renders as expected with Bedrock CSS (?bedrock)♿ tested for WCAG 2.1 AA accessibility compliance📝 tested in Chrome, Firefox, Safari, and Edge