chore(deps): update typescript-eslint monorepo to v4 (major)

[renovate]

This PR contains the following updates:

Package	Type	Update	Change
@typescript-eslint/eslint-plugin	devDependencies	major	3.10.1 -> 4.3.0
@typescript-eslint/parser	devDependencies	major	3.10.1 -> 4.3.0

---

Release Notes

typescript-eslint/typescript-eslint

v4.3.0

Compare Source

Bug Fixes

• eslint-plugin: added safe getTypeOfPropertyOfType wrapper (#​2567) (7cba2de)
• experimental-utils: treat RuleTester arrays as readonly (#​2601) (8025777)

Features

• eslint-plugin: [no-invalid-void-type] add option to allow this: void (#​2481) (ddf5660)

v4.2.0

Compare Source

Bug Fixes

• eslint-plugin: [naming-convention] ignore properties inside object patterns (#​2566) (53a3cbc)
• eslint-plugin: [prefer-ts-expect-error] support block comments (#​2541) (c6f72fb)
• scope-manager: correct analysis of inferred types in conditional types (#​2537) (4f660fd)

Features

• eslint-plugin: add extension rule comma-dangle (#​2416) (f7babcf)

4.1.1 (2020-09-14)

Bug Fixes

• eslint-plugin: [naming-convention] allow an array of selectors with types and modifiers (#​2415) (7ca54c3)
• eslint-plugin: [no-implied-eval] handle the Function type (#​2435) (e1401dc)
• eslint-plugin: [no-unused-vars] better handling for declared modules (#​2553) (02d72d4), closes #​2523
• eslint-plugin: [no-use-before-define] false positive for function type arguments (#​2554) (189162d), closes #​2527
• eslint-plugin: [prefer-function-type] handle this return (#​2437) (7c6fcee)
• eslint-plugin: [return-await] don't error for in-try-catch if the return is in a catch without a finally (#​2356) (efdd521)
• types: artificial fix needed to trigger release (b577daf)
• types: artificial fix needed to trigger release (fc62ba8)

v4.1.1

Compare Source

Bug Fixes

• eslint-plugin: [naming-convention] allow an array of selectors with types and modifiers (#​2415) (7ca54c3)
• eslint-plugin: [no-implied-eval] handle the Function type (#​2435) (e1401dc)
• eslint-plugin: [no-unused-vars] better handling for declared modules (#​2553) (02d72d4), closes #​2523
• eslint-plugin: [no-use-before-define] false positive for function type arguments (#​2554) (189162d), closes #​2527
• eslint-plugin: [prefer-function-type] handle this return (#​2437) (7c6fcee)
• eslint-plugin: [return-await] don't error for in-try-catch if the return is in a catch without a finally (#​2356) (efdd521)
• types: artificial fix needed to trigger release (b577daf)
• types: artificial fix needed to trigger release (fc62ba8)

v4.1.0

Compare Source

Bug Fixes

• eslint-plugin: [explicit-module-boundary-types] cyclical reference infinite recursion crash (#​2482) (8693653)
• eslint-plugin: [no-unused-vars] correct detection of unused vars in a declared module with export = (#​2505) (3d07a99)
• eslint-plugin: [no-unused-vars] properly handle ambient declaration exports (#​2496) (4d3ce5f)
• eslint-plugin: [no-use-before-define] false positive with jsx pragma reference (#​2503) (5afeeab), closes #​2502
• eslint-plugin: [typedef] false positive for rest parameter with array destructuring (#​2441) (2ada5af)
• eslint-plugin: handle missing message IDs in eslint v5/v6 (#​2461) (ffdfade)
• scope-manager: add const as a global type variable (#​2499) (eb3f6e3)
• scope-manager: correctly handle inferred types in nested type scopes (#​2497) (95f6bf4)
• scope-manager: don't create references for intrinsic JSX elements (#​2504) (cdb9807)
• scope-manager: fallback to lib 'esnext' or 'es5' when ecma version is unsupported (#​2474) (20a7dcc)
• scope-manager: support rest function type parameters (#​2491) (9d8b4c4), closes #​2449
• scope-manager: support tagged template string generic type parameters (#​2492) (a2686c0)
• scope-manager: support type predicates (#​2493) (a40f54c), closes #​2462
• scope-manager: treat type imports as both values and types (#​2494) (916e95a), closes #​2453

Features

• eslint-plugin: [no-shadow] add option ignoreFunctionTypeParameterNameValueShadow (#​2470) (bfe255f)
• eslint-plugin: add extension rule no-loop-func (#​2490) (36305df)
• scope-manager: add support for JSX scope analysis (#​2498) (f887ab5), closes #​2455 #​2477

4.0.1 (2020-08-31)

Bug Fixes

• eslint-plugin: update parser dependency range (#​2445) (2cb6620), closes #​2444

v4.0.1

Compare Source

Bug Fixes

• eslint-plugin: update parser dependency range (#​2445) (2cb6620), closes #​2444

v4.0.0

Compare Source

Please see the release notes for v4.0.0

Bug Fixes

• eslint-plugin: [no-shadow] fix false-positive on enum declaration (#​2374) (9de669f)
• eslint-plugin: [no-unused-vars] handle TSCallSignature (#​2336) (c70f54f)
• correct decorator traversal for AssignmentPattern (#​2375) (d738fa4)
• scope-manager: correct analysis of abstract class properties (#​2420) (cd84549)
• typescript-estree: correct ChainExpression interaction with parentheses and non-nulls (#​2380) (762bc99)

Features

• consume new scope analysis package (#​2039) (3be125d)
• support ESTree optional chaining representation (#​2308) (e9d2ab6)
• eslint-plugin: [ban-ts-comment] change default for ts-expect-error to allow-with-description (#​2351) (a3f163a), closes #​2146
• eslint-plugin: [no-unnecessary-condition][strict-boolean-expressions] add option to make the rules error on files without strictNullChecks turned on (#​2345) (9273441)
• eslint-plugin: [typedef] remove all defaults (#​2352) (a9cd6fb)
• eslint-plugin: add consistent-type-imports rule (#​2367) (58b1c2d)
• typescript-estree: switch to globby (#​2418) (3a7ec9b), closes #​2398

BREAKING CHANGES

• typescript-estree: - removes the ability to supply a RegExp to projectFolderIgnoreList, and changes the meaning of the string value from a regex to a glob.

• • Removed decorators property from several Nodes that could never semantically have them (FunctionDeclaration, TSEnumDeclaration, and TSInterfaceDeclaration)

• Removed AST_NODE_TYPES.Import. This is a minor breaking change as the node type that used this was removed ages ago.

• eslint-plugin: Default rule options is a breaking change.

3.10.1 (2020-08-25)

Bug Fixes

• eslint-plugin: [no-unnecessary-condition] correct regression with unary negations (#​2422) (d1f0887), closes #​2421

---

Renovate configuration

📅 Schedule: "on Monday every 8 weeks of the year starting on the 5th week" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[austingreendev]

May need to close this until typescript-eslint/typescript-eslint#2540 is resolved

[hzhu]

In the meantime the major can be updated to v4.0.1 rather than v4.3.0, similar to zendeskgarden/website#184 (review).

[jzempel]

Excellent. Let's do that @hzhu.

[hzhu]

It looks like I spoke too soon 😔 .

Upgrading to 4.0.1 results in a new (unrelated) issue where ESlint incorrectly identifies unused vars with styled-components. The issue is described here: typescript-eslint/typescript-eslint#2452. There is a fix for this issue in 4.1.0.

Unfortunately, upgrading to 4.1.0 would result in the original issue where ESLint errors out because "React was used before it was defined". Due to this, it might be worthwhile reverting the upgrade in the website project.

[renovate]

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 4.x releases. However, if you upgrade to 4.x manually then Renovate will then reenable updates for minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

[hzhu]

Upon realizing this repo doesn't use Gatsby, I realized there aren't any dependencies using a lower version of v4 of @typescript-eslint:

Upon further investigation, it looks like following step 1 outlined here should allow this project to use the latest major version 🤞 .

[coveralls]

Coverage remained the same at 95.833% when pulling d5a0a76 on renovate/major-typescript-eslint-monorepo into 0223a77 on main.

[jzempel]

@hzhu Garden's config is no-use-before-define results in an "error". This should probably match.

ref https://github.com/zendeskgarden/eslint-config/blob/a847e6d8feb3a3630455afe6d7af642f4d8018f3/rules/variables.js#L36