Fixed a potential issue on rand usage

zendframework · Nov 23, 2015 · 5561ef8 · 5561ef8
1 parent 8b2d22b
commit 5561ef8
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/AbstractWord.php b/src/AbstractWord.php
@@ -309,10 +309,12 @@ protected function generateWord()
         $vowels     = $this->useNumbers ? static::$VN : static::$V;
         $consonants = $this->useNumbers ? static::$CN : static::$C;
 
+        $totIndexCon = count($consonants) - 1;
+        $totIndexVow = count($vowels) - 1;
         for ($i=0; $i < $wordLen; $i = $i + 2) {
             // generate word with mix of vowels and consonants
-            $consonant = $consonants[array_rand($consonants)];
-            $vowel     = $vowels[array_rand($vowels)];
+            $consonant = $consonants[Rand::getInteger(0, $totIndexCon, true)];
+            $vowel     = $vowels[Rand::getInteger(0, $totIndexVow, true)];
             $word     .= $consonant . $vowel;
         }