From 466f249d772c188d1370545aba65bf0126bdfef0 Mon Sep 17 00:00:00 2001 From: Remi Collet Date: Mon, 15 Oct 2018 08:53:35 +0200 Subject: [PATCH 1/3] Fix for PHP 7.3: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? --- src/Transfer/Adapter/AbstractAdapter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Transfer/Adapter/AbstractAdapter.php b/src/Transfer/Adapter/AbstractAdapter.php index bc90dfe..48b615d 100644 --- a/src/Transfer/Adapter/AbstractAdapter.php +++ b/src/Transfer/Adapter/AbstractAdapter.php @@ -545,7 +545,7 @@ public function setOptions($options = [], $files = null) break; default: - continue; + break; } } } From 56d2577e20179b304d0bdf53d550c6570e12fcb2 Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Mon, 15 Oct 2018 17:37:44 +1000 Subject: [PATCH 2/3] Add changelog for #45 --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ac84966..69dbccb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -22,7 +22,8 @@ All notable changes to this project will be documented in this file, in reverse ### Fixed -- Nothing. +- [#45](https://github.com/zendframework/zend-file/pull/45) fixes compatibility + issue with php 7.3 with deprecated continue keyword usage in switch statements ## 2.8.1 - 2018-05-01 From 4ecb2f67b04aa4ad5fddf27bd39222e867ec80b4 Mon Sep 17 00:00:00 2001 From: Aleksei Khudiakov Date: Mon, 15 Oct 2018 17:42:09 +1000 Subject: [PATCH 3/3] Add php 7.3 to travis build matrix --- .travis.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.travis.yml b/.travis.yml index 2fb1fd4..2f096db 100644 --- a/.travis.yml +++ b/.travis.yml @@ -53,6 +53,15 @@ matrix: - php: 7.2 env: - DEPS=latest + - php: 7.3 + env: + - DEPS=lowest + - php: 7.3 + env: + - DEPS=locked + - php: 7.3 + env: + - DEPS=latest before_install: - if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi