apply integer and numeric check

Author: samsonasik

src/Client/Adapter/Curl.php

@@ -202,12 +202,24 @@ public function connect($host, $port = 80, $secure = false)
         }
 
         if (isset($this->config['connecttimeout'])) {
-            $connectTimeout = (int) $this->config['connecttimeout'];
+            $connectTimeout = $this->config['connecttimeout'];
         } elseif (isset($this->config['timeout'])) {
-            $connectTimeout = (int) $this->config['timeout'];
+            $connectTimeout = $this->config['timeout'];
         } else {
             $connectTimeout = null;
         }
+
+        if ($connectTimeout !== null && (! is_int($connectTimeout) || ! is_numeric($connectTimeout))) {
+            throw new AdapterException\InvalidArgumentException(sprintf(
+                'integer or numeric string expected, got %s',
+                gettype($connectTimeout)
+            ));
+        }
+
+        if ($connectTimeout !== null) {
+            $connectTimeout = (int) $connectTimeout;
+        }
+
         if ($connectTimeout !== null) {
             if (defined('CURLOPT_CONNECTTIMEOUT_MS')) {
                 curl_setopt($this->curl, CURLOPT_CONNECTTIMEOUT_MS, $connectTimeout * 1000);

test/Client/CurlTest.php

@@ -96,20 +96,34 @@ public function testConfigSetAsZendConfig()
         $this->assertEquals($config->nested->item, $hasConfig['nested']['item']);
     }
 
+    public function provideValidTimeoutConfig()
+    {
+        return [
+            'integer' => [10],
+            'numeric' => ['10'],
+        ];
+    }
+
     /**
-     * Test not integer timeout casted to int
-     *
+     * @dataProvider provideValidTimeoutConfig
      */
-    public function testCastTimeOutConfig()
+    public function testPassValidTimeout($timeout)
     {
-        $config = new Config([
-            'timeout'  => "timeout",
-        ]);
+        $adapter = new Adapter\Curl();
+        $adapter->setOptions(['timeout' => $timeout]);
 
-        $this->_adapter->setOptions($config);
+        $adapter->connect('http://framework.zend.com');
+    }
 
-        $hasConfig = $this->_adapter->getConfig();
-        $this->assertEquals((int) $config->timeout, $hasConfig['timeout']);
+    public function testThrowInvalidArgumentExceptionOnNonIntegerAndNonNumericStringTimeout()
+    {
+        $adapter = new Adapter\Curl();
+        $adapter->setOptions(['timeout' => 'timeout']);
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('integer or numeric string expected, got string');
+
+        $adapter->connect('http://framework.zend.com');
     }
 
     /**