From ef03544a15a30b0c0ec08f460e322a6af57a0bc8 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Thu, 4 Jun 2015 04:55:54 +0700 Subject: [PATCH 1/2] drop PHP 5.4 check --- test/ValueTest.php | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/test/ValueTest.php b/test/ValueTest.php index ce2e96b..e6298e8 100644 --- a/test/ValueTest.php +++ b/test/ValueTest.php @@ -406,10 +406,8 @@ public function testArrayMustContainDataElement(Generator $generator) */ public function testMarshalNilInStructWrappedInArray(Generator $generator) { - if (version_compare(phpversion(), '5.4', '>=')) { - // SimpleXMLElement don't understand NIL - $this->markTestIncomplete('Code to test is not compatible with PHP 5.4'); - } + // SimpleXMLElement don't understand NIL + $this->markTestIncomplete('Code to test is not compatible with PHP >5.4'); AbstractValue::setGenerator($generator); $expected = [['id' => '1', 'name' => 'vertebra, caudal', 'description' => null]]; From f92b9d83bf310904f9e09b680cd847e00842a835 Mon Sep 17 00:00:00 2001 From: Abdul Malik Ikhsan Date: Wed, 21 Oct 2015 19:35:37 +0700 Subject: [PATCH 2/2] removed function test as not compatible with php > 5.4 --- test/ValueTest.php | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/test/ValueTest.php b/test/ValueTest.php index e6298e8..3521517 100644 --- a/test/ValueTest.php +++ b/test/ValueTest.php @@ -400,26 +400,6 @@ public function testArrayMustContainDataElement(Generator $generator) $val = AbstractValue::getXmlRpcValue($xml, AbstractValue::XML_STRING); } - /** - * @group ZF-5405 - * @dataProvider ZendTest\XmlRpc\TestProvider::provideGenerators - */ - public function testMarshalNilInStructWrappedInArray(Generator $generator) - { - // SimpleXMLElement don't understand NIL - $this->markTestIncomplete('Code to test is not compatible with PHP >5.4'); - - AbstractValue::setGenerator($generator); - $expected = [['id' => '1', 'name' => 'vertebra, caudal', 'description' => null]]; - $xml = '' - . 'id1' - . 'namevertebra, caudal' - . 'description' - . ''; - $val = AbstractValue::getXmlRpcValue($xml, AbstractValue::XML_STRING); - $this->assertSame($expected, $val->getValue()); - } - // Struct public function testFactoryAutodetectsStruct()