-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stm32u5 hal dma_ex function not inlined with GCC 11 or 12 #115
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Did you submit this fix upstream? I could not find anything with the
Change-Id
mentioned. - When this is done, make sure to cherry pick the upstream commit into the Zephyr fork by using the
-x
option ofgit cherry-pick
to keep track of the cherry-picked commit. - This PR is not quite solving the issue in Zephyr by itself. The issue will be solved in Zephyr once this PR is merged and that commit is integrated into Zephyr. For that you will need to create a manifest PR in the Zephyr repository (see PRs with the
manifest-trusted-firmware-m
label for examples), and there you can have theFixes X
.
@tomi-font Even If I push this change on ~/zephyrproject/modules/tee/tf-m/trusted-firmware-m Where Should my change be ? on top of remotes/upstream/main or on a11cd27 or ? |
First, where in Zephyr would you like this fix to be included? And I'm not sure I get what you're saying, but it's normal that the end commit hashes differ even when cherry picking the commit (because the two branches are not identical.) Anyway, we'll want to wait for your patch to be approved upstream before merging it here. |
@tomi-font TF-M upstream team won't integrate the change until PR is merged and delivered in official HAL package (they don't merge HAL fixes). See https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/33420. |
Can't you somehow speed up the process on the HAL side? Anyway, sure we can integrate that faster into Zephyr. But can you rework the commit to cherry pick the one you submitted upstream with the |
That's not only about merging this fix. It's about integrating it in a newSTM32Cube package version, perform validation and deliver. Then this Cube package should be integrated into TF-M, validated, then upstreamed. That's a long process.
Ok, great. Thanks
Sure, we'll do. |
refer to https://review.trustedfirmware.org/c/TF-M/trusted-firmware-m/+/33420 Signed-off-by: F. Ramu <francois.ramu@st.com> (cherry picked from commit 7cd6c20)
commit msg now mentions the reference for the cherry picked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the changes identical between this PR and your upstream one.
Also, you will need a PR in Zephyr to update the reference to this repo in order to pull those changes in. While this PR is not merged, the revision
should be pull/115/head
.
Takes the PR zephyrproject-rtos/trusted-firmware-m#115 to fix the build error on stm32u5 due to gcc revision Signed-off-by: Francois Ramu <francois.ramu@st.com>
done in zephyrproject-rtos/zephyr#82534 |
Takes the PR zephyrproject-rtos/trusted-firmware-m#115 to fix the build error on stm32u5 due to gcc revision Signed-off-by: Francois Ramu <francois.ramu@st.com>
Takes the PR zephyrproject-rtos/trusted-firmware-m#115 to fix the build error on stm32u5 due to gcc revision Signed-off-by: Francois Ramu <francois.ramu@st.com>
Fix the Issue linked to compilation of file HAL_DMAEx_List_ReplaceNode_Head.c
using a GCC version comprised between v11.x and v12.x.
and blocking the zephyr CI
Issue is seen only with TF-M build config RelWithDebInfo (With MinSizeRel config, this file is not built).
Issue could be fixed by "adding attribute ((no_inline)) to DMA_List_CheckNodesBaseAddresses allows the build to pass"
Zephyr issue: zephyrproject-rtos/zephyr#80932